Skip to content

Update atmos_bufr_prepobs.py for restriction logic #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HyundeokChoi-NOAA merged 4 commits into from
Apr 6, 2026
+20 −3
Merged

Update atmos_bufr_prepobs.py for restriction logic #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
612ce11
Update atmos_bufr_prepobs.py for restriction logic
Apr 2, 2026
a2fcfa1
Add unified restriction filter import from build/bin
Apr 2, 2026
e740766
update task import alias to restriction_filter
Apr 3, 2026
fdbbbc4
Update da-utils submodule to latest develop
Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sorc/da-utils
Open in desktop
Submodule da-utils updated 2 files
+17 −0 src/CMakeLists.txt
+401 −0 src/ioda-restrict/ioda_restriction_filter.py
2 changes: 1 addition & 1 deletion ush/python/pyobsforge/task/aero_prepobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def finalize(self) -> None:
'output file': str(ready_file),
}
save_as_yaml(summary_dict, os.path.join(self.task_config.DATA, "stats.yaml"))
exec_cmd = Executable(os.path.join(self.task_config.HOMEobsforge, "build", "bin", "ioda-dump.x"))
exec_cmd = Executable(os.path.join(self.task_config.HOMEobsforge, "build", "bin", "ioda-summary.x"))
exec_cmd.add_default_arg(os.path.join(self.task_config.DATA, "stats.yaml"))
try:
logger.info(f"Creating summary file {ready_file}")
Expand Down
19 changes: 18 additions & 1 deletion ush/python/pyobsforge/task/atmos_bufr_prepobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def finalize(self) -> None:
'output file': str(ready_file),
}
save_as_yaml(summary_dict, os.path.join(self.task_config.DATA, "stats.yaml"))
exec_cmd = Executable(os.path.join(self.task_config.HOMEobsforge, "build", "bin", "ioda-dump.x"))
exec_cmd = Executable(os.path.join(self.task_config.HOMEobsforge, "build", "bin", "ioda-summary.x"))
exec_cmd.add_default_arg(os.path.join(self.task_config.DATA, "stats.yaml"))
try:
logger.info(f"Creating summary file {ready_file}")
Expand All @@ -266,3 +266,20 @@ def finalize(self) -> None:
logger.warning(f"Failed to create summary file {ready_file}: {e}")
logger.warning("Creating an empty ready file instead")
ready_file.touch()

# Run unified restriction filter AFTER finalize
stats_yaml = os.path.join(self.task_config.DATA, "stats.yaml")

logger.info(f"Running unified restriction filter using {stats_yaml}")

# Add ioda-restrict directory to PYTHONPATH so we can import it
import sys

sys.path.append(os.path.join(self.task_config.HOMEobsforge, "build", "bin"))

from ioda_restriction_filter import run_rsrd_exprsrd as restriction_filter

try:
restriction_filter(stats_yaml)
except Exception as e:
logger.warning(f"ioda_restriction_filter.py failed: {e}")
Loading