Link gsi diag.* directories instead of moving them#4545
Merged
DavidHuber-NOAA merged 5 commits intoNOAA-EMC:developfrom Feb 13, 2026
Merged
Link gsi diag.* directories instead of moving them#4545DavidHuber-NOAA merged 5 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA merged 5 commits intoNOAA-EMC:developfrom
Conversation
DavidHuber-NOAA
requested review from
CoryMartin-NOAA and
RussTreadon-NOAA
as code owners
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
RussTreadon-NOAA
approved these changes
Feb 12, 2026
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Did not test but looks good to me.
Approve.
8 tasks
Contributor
|
@DavidHuber-NOAA : Any more tests you want to run on this change? I'm keen to see it enter g-w |
Contributor
Author
|
@RussTreadon-NOAA Let's go ahead and merge this as a hot fix. I'll run some additional tests on WCOSS2 afterwards and verify the jobs are running as intended. |
Contributor
|
Thank you @DavidHuber-NOAA for merging. Last night's run of GDASApp stable-nightly failed on Hera due to the problem this PR resolves. A rerun using |
9 tasks
DavidHuber-NOAA
added a commit
that referenced
this pull request
Feb 26, 2026
…ails in v17 (#4574) This is a cherry-pick of PRs #4545 and #4458 into dev/gfs.v17. This - fixes a bug that prevents rerunning atmospheric analyses (`gdas_anal`, `gfs_anal`, or `enkfgdas_eobs`) - moves to an improved and NCO-approved method of linking instead of moving the gsidiag files at the end of the jobs - enables scrontab emailing on Gaea C6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes the code more in line with operational requirements by using links instead of moving the diag.* directories while running the GSI. This also deletes the
gsidiagsdirectory inDATAROOTbefore linking to it to ensure that reruns ofgdas_analandenkfgdas_eobsonly retain the newly-generated data inDATAROOT.Resolves #4543
Resolves #4479
Follow-on PR to #4487
Type of change
Change characteristics
How has this been tested?
/gpfs/f6/drsa-hurr1/world-shared/David.Huber/rt_gsidiagsDATAandGSIDIAGDIRdirectories and data for an enkfgdas_eobs jobDATA:/gpfs/f6/drsa-precip3/world-shared/David.Huber/RUNDIRS/C96C48_hybatmsnowDA_gsidiags/enkfgdas.2021122100/eobs.1197701GSIDIAGDIR:/gpfs/f6/drsa-precip3/world-shared/David.Huber/RUNDIRS/C96C48_hybatmsnowDA_gsidiags/enkfgdas.2021122100/C96C48_hybatmsnowDA_gsidiags/enkfgdas.20211221/00/ensstat/analysis/atmos/gsidiagsChecklist