Make GDASApp compiler with container#2066
Make GDASApp compiler with container#2066RussTreadon-NOAA merged 18 commits intoNOAA-EMC:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds basic “container” platform support so GDASApp can be built (and potentially run) inside a containerized environment, aligning with Global-Workflow’s container-based compilation approach.
Changes:
- Detect container execution and set
MACHINE_ID=container. - Add container handling to module initialization (
module-setup.sh) and tobuild.shsupported targets. - Introduce a new Lmod modulefile for
GDAS/container.intel.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
ush/module-setup.sh |
Adds a container branch to initialize Lmod and purge modules. |
ush/detect_machine.sh |
Forces MACHINE_ID=container when SINGULARITY_CONTAINER is set. |
modulefiles/GDAS/noaacloud.intel.lua |
Adds commented alternative data path environment variables. |
modulefiles/GDAS/container.intel.lua |
New container-specific Intel toolchain + dependency modulefile. |
build.sh |
Allows container as a recognized build target for module loading. |
|
Automated GW-GDASApp Testing Results: |
|
Automated GW-GDASApp Testing Results: |
|
The Ursa failures are a known problem. g-w PR #4545 will resolve this problem. These failures are not due to the changes in this PR. |
|
Automated GW-GDASApp Testing Results: |
|
Automated GW-GDASApp Testing Results: |
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
GDASApp CI passes on Gaea C6, Hercules, and Ursa - an expected result.
Approve.
|
@weihuang-jedi : Cory is on leave. I will merge this PR as is with note that additional work is required. |
|
@RussTreadon-NOAA |
Description
With Global-Workflow forecast (UFS-model, ufs-utils, gfs-utils) compile and run with container, want to make GDASApp work with container as well.
Issues
Resolves #2065
Automated CI tests to run in Global Workflow