Skip to content

Make GDASApp compiler with container#2066

Merged
RussTreadon-NOAA merged 18 commits intoNOAA-EMC:developfrom
NOAA-EPIC:feature/use_container_spack-stack-1.9.2
Feb 13, 2026
Merged

Make GDASApp compiler with container#2066
RussTreadon-NOAA merged 18 commits intoNOAA-EMC:developfrom
NOAA-EPIC:feature/use_container_spack-stack-1.9.2

Conversation

@weihuang-jedi
Copy link
Collaborator

@weihuang-jedi weihuang-jedi commented Feb 12, 2026

Description

With Global-Workflow forecast (UFS-model, ufs-utils, gfs-utils) compile and run with container, want to make GDASApp work with container as well.

Issues

Resolves #2065

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmsnowDA
  • C96_gcafs_cycled
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_ufsgsi_hybatmDA
  • C96C48_hybatmDA

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds basic “container” platform support so GDASApp can be built (and potentially run) inside a containerized environment, aligning with Global-Workflow’s container-based compilation approach.

Changes:

  • Detect container execution and set MACHINE_ID=container.
  • Add container handling to module initialization (module-setup.sh) and to build.sh supported targets.
  • Introduce a new Lmod modulefile for GDAS/container.intel.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
ush/module-setup.sh Adds a container branch to initialize Lmod and purge modules.
ush/detect_machine.sh Forces MACHINE_ID=container when SINGULARITY_CONTAINER is set.
modulefiles/GDAS/noaacloud.intel.lua Adds commented alternative data path environment variables.
modulefiles/GDAS/container.intel.lua New container-specific Intel toolchain + dependency modulefile.
build.sh Allows container as a recognized build target for module loading.

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Feb 12, 2026
@RussTreadon-NOAA RussTreadon-NOAA added ursa-GW-RT hercules-GW-RT Queue for automated testing with global-workflow on Hercules gaeac6-GW-RT labels Feb 12, 2026
@emcbot emcbot added hercules-GW-RT-Running Automated testing with global-workflow running on Hercules and removed hercules-GW-RT Queue for automated testing with global-workflow on Hercules labels Feb 12, 2026
@emcbot
Copy link

emcbot commented Feb 12, 2026

Automated GW-GDASApp Testing Results:
Machine: hercules

Start: Thu Feb 12 14:32:57 CST 2026 on hercules-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Feb 12 14:49:32 CST 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Thu Feb 12 15:22:02 CST 2026
Tests: 100% tests passed, 0 tests failed out of 144

@emcbot emcbot added hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules gaeac6-GW-RT-Running and removed hercules-GW-RT-Running Automated testing with global-workflow running on Hercules gaeac6-GW-RT labels Feb 12, 2026
@emcbot
Copy link

emcbot commented Feb 12, 2026

Automated GW-GDASApp Testing Results:
Machine: ursa

Start: Thu Feb 12 20:31:57 UTC 2026 on ufe04
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Feb 12 20:43:28 UTC 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                  *Failed*
Tests: Failed at Thu Feb 12 21:34:07 UTC 2026
Tests: 97% tests passed, 5 tests failed out of 144
	188 - test_gdasapp_C96C48_hybatmDA_gdas_anal_202112210000 (Failed)
	192 - test_gdasapp_C96C48_hybatmDA_enkfgdas_eobs_202112210000 (Failed)
	237 - test_gdasapp_C96C48_ufsgsi_hybatmDA_enkfgdas_eobs_202402240000 (Failed)
	268 - test_gdasapp_C96C48_hybatmsnowDA_gdas_anal_202112201800 (Failed)
	273 - test_gdasapp_C96C48_hybatmsnowDA_enkfgdas_eobs_202112201800 (Failed)
Tests: see output at /scratch3/NCEPDEV/da/role.jedipara/CI/ursa/GDASApp/workflow/PR/2066/global-workflow/sorc/gdas.cd/build/log.ctest

@RussTreadon-NOAA
Copy link
Contributor

The Ursa failures are a known problem. g-w PR #4545 will resolve this problem. These failures are not due to the changes in this PR.

@emcbot
Copy link

emcbot commented Feb 12, 2026

Automated GW-GDASApp Testing Results:
Machine: gaeac6

Start: Thu Feb 12 04:32:04 PM EST 2026 on gaea62
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Feb 12 04:51:40 PM EST 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Thu Feb 12 05:22:46 PM EST 2026
Tests: 100% tests passed, 0 tests failed out of 144

@emcbot
Copy link

emcbot commented Feb 12, 2026

Automated GW-GDASApp Testing Results:
Machine: ursa

Start: Thu Feb 12 21:46:47 UTC 2026 on ufe04
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Feb 12 21:58:18 UTC 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Thu Feb 12 22:53:03 UTC 2026
Tests: 100% tests passed, 0 tests failed out of 144

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GDASApp CI passes on Gaea C6, Hercules, and Ursa - an expected result.

Approve.

@RussTreadon-NOAA
Copy link
Contributor

@weihuang-jedi : Cory is on leave. I will merge this PR as is with note that additional work is required.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 9f74c9c into NOAA-EMC:develop Feb 13, 2026
33 checks passed
@weihuang-jedi
Copy link
Collaborator Author

@RussTreadon-NOAA
Thank you for reviewing, testing, and merging in a quickly manner!
Wei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gaeac6-GW-RT-Passed hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules ursa-GW-RT-Passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make GDASApp compiler with container

5 participants