Fix two bugfixes to global_cycle.sh by ClaraDraper-NOAA · Pull Request #4327 · NOAA-EMC/global-workflow

ClaraDraper-NOAA · 2025-12-12T20:38:56Z

Description

This PR fixes two small bugs in global_cycle.sh:

In sfc_nam namelist used by sfc_sub, set time to match the restart time, rather than the analysis time.
By default in sfc_name namelist, turn off the soil moisture relxation scheme.

resolves #4326
resolves #4325

Type of change

[x ] Bug fix (fixes something broken)
New feature (adds functionality)
Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES/NO (If YES, please indicate to which system(s))
Will change values in sfcanl_data
- GFS
- GEFS
- SFS
- [NO] GCAFS
Is this a breaking change (a change in existing functionality)? YES/NO
NO
Does this change require a documentation update? YES/NO
NO
Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.)

NO

How has this been tested?

Checklist

[x ] Any dependent changes have been merged and published
[x ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
[x ] I have commented my code, particularly in hard-to-understand areas
[x ] I have documented my code, including function, input, and output descriptions
[ x] My changes generate no new warnings
New and existing tests pass with my changes
[x ] This change is covered by an existing CI test or a new one has been added
[ x] Any new scripts have been added to the .github/CODEOWNERS file with owners
[ x] I have made corresponding changes to the system documentation if necessary

correct the date in the gcycle namelist.

get output from both calls to gcycle.

ClaraDraper-NOAA · 2025-12-15T20:03:43Z

C96C48_hybatmsoilDA experiment ran on USRA. Converting from draft.

ClaraDraper-NOAA · 2025-12-15T20:42:17Z

Also, note that this bugfix will also avoid the secondary bug described here (liquid soil moisture incorrectly set to 1 along coast lines in layers 2-4), as described here.

DavidHuber-NOAA

Looks good. Thanks for this bugfix @ClaraDraper-NOAA!

DavidHuber-NOAA · 2025-12-16T14:34:40Z

Launching tests on Hercules.

emcbot · 2025-12-16T16:06:10Z

C96C48mx500_S2SW_cyc_gfs FAILED on Hercules (pipeline ID: 6388)

In directory: /work2/noaa/global/role-global/GFS_CI_CD/HERCULES/BUILDS/GITLAB/pr_cases_4327_a05fd274_6388/RUNTESTS/EXPDIR/C96C48mx500_S2SW_cyc_gfs_a05fd274-6388

Error Log Files:


/work2/noaa/global/role-global/GFS_CI_CD/HERCULES/BUILDS/GITLAB/pr_cases_4327_a05fd274_6388/RUNTESTS/COMROOT/C96C48mx500_S2SW_cyc_gfs_a05fd274-6388/logs/2021122018/enkfgfs_esfc.log

View Error Logs: (enkfgfs_esfc.log)

This failure was detected automatically by global-workflow's CI/CD Pipeline

emcbot · 2025-12-16T16:12:01Z

C48mx500_hybAOWCDA FAILED on Hercules (pipeline ID: 6388)

In directory: /work2/noaa/global/role-global/GFS_CI_CD/HERCULES/BUILDS/GITLAB/pr_cases_4327_a05fd274_6388/RUNTESTS/EXPDIR/C48mx500_hybAOWCDA_a05fd274-6388

Error Log Files:


/work2/noaa/global/role-global/GFS_CI_CD/HERCULES/BUILDS/GITLAB/pr_cases_4327_a05fd274_6388/RUNTESTS/COMROOT/C48mx500_hybAOWCDA_a05fd274-6388/logs/2021032500/enkfgdas_esfc.log

View Error Logs: (enkfgdas_esfc.log)

This failure was detected automatically by global-workflow's CI/CD Pipeline

emcbot · 2025-12-16T16:18:08Z

C96C48_hybatmDA FAILED on Hercules (pipeline ID: 6388)

In directory: /work2/noaa/global/role-global/GFS_CI_CD/HERCULES/BUILDS/GITLAB/pr_cases_4327_a05fd274_6388/RUNTESTS/EXPDIR/C96C48_hybatmDA_a05fd274-6388

Error Log Files:


/work2/noaa/global/role-global/GFS_CI_CD/HERCULES/BUILDS/GITLAB/pr_cases_4327_a05fd274_6388/RUNTESTS/COMROOT/C96C48_hybatmDA_a05fd274-6388/logs/2021122100/enkfgdas_esfc.log

View Error Logs: (enkfgdas_esfc.log)

This failure was detected automatically by global-workflow's CI/CD Pipeline

RussTreadon-NOAA · 2025-12-16T16:33:18Z

@ClaraDraper-NOAA , enkfgdas_esfc fails because gcycle_date is not defined when it is executed. dev/scripts/exglobal_enkf_sfc.sh needs to define and export gcycle_date like dev/scripts/exglobal_atmos_sfcanl.sh does.

ClaraDraper-NOAA · 2025-12-16T19:11:01Z

@ClaraDraper-NOAA , enkfgdas_esfc fails because gcycle_date is not defined when it is executed. dev/scripts/exglobal_enkf_sfc.sh needs to define and export gcycle_date like dev/scripts/exglobal_atmos_sfcanl.sh does.

Thanks Russ. That was me being sloppy with my committing. I'm double checking it's OK now.

DavidHuber-NOAA · 2025-12-17T18:14:41Z

@ClaraDraper-NOAA Let me know when this is ready for re-review and testing.

ClaraDraper-NOAA · 2025-12-17T18:17:56Z

@ClaraDraper-NOAA Let me know when this is ready for re-review and testing.

@DavidHuber-NOAA Thanks for following-up. It's ready to re-review and testing.

DavidHuber-NOAA · 2025-12-17T18:20:13Z

Launching tests on C6.

DavidHuber-NOAA · 2025-12-17T18:51:10Z

C6 builds are stalling due to a new policy on compute node builds. Cancelling C6 CI and launching on Hercules.

CatherineThomas-NOAA

Did not test myself, but the fixes look consistent with the identified bugs. Thanks @ClaraDraper-NOAA! Approved pending successful CI tests.

ClaraDraper-NOAA · 2025-12-17T19:31:08Z

BUILD FAILED on Gaeac6 (pipeline ID: 6444)

In directory: /gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4327_7f875e8c_6444/global-workflow/sorc

Error log files:
[View Error Logs](File /gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4327_7f875e8c_6444/global-workflow/sorc/logs/gfs_model.log does not exist File /gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4327_7f875e8c_6444/global-workflow/sorc/logs/gefs_model.log does not exist File /gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4327_7f875e8c_6444/global-workflow/sorc/logs/sfs_model.log does not exist File /gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4327_7f875e8c_6444/global-workflow/sorc/logs/gcafs_model.log does not exist File /gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4327_7f875e8c_6444/global-workflow/sorc/logs/gsi_enkf.log does not exist File /gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4327_7f875e8c_6444/global-workflow/sorc/logs/gdas.log does not exist)

This failure was detected automatically by global-workflow's CI/CD Pipeline

This looks like it's coming from @DavidHuber-NOAA 's aborted c6 runs?

DavidHuber-NOAA · 2025-12-17T19:32:25Z

@CatherineThomas-NOAA Yes, I just killed the build jobs that were stuck in the queue.

DavidHuber-NOAA · 2025-12-17T19:32:45Z

Sorry, @ClaraDraper-NOAA ^^^

This PR corrects the soil relaxation bug in v17 retros, resolving issue [#](#4326) In develop, this fix was included in a PR [#4327](#4327) which included an additional change to correct a long-standing error in the time input to global_cycle. The latter change has not been tested sufficiently for inclusion into v17 retros, so I've created this PR to merge in only the soil relaxation change to v17.

ClaraDraper-NOAA added 2 commits December 12, 2025 20:19

Changes to global_cycle, to turn off soil moisture relaxation and to

64f3aac

correct the date in the gcycle namelist.

export gcycle_date, and change piping for PGMOUT in global_cycle.sh to

20f249c

get output from both calls to gcycle.

ClaraDraper-NOAA marked this pull request as ready for review December 15, 2025 20:03

ClaraDraper-NOAA requested review from BrianCurtis-NOAA and aerorahul as code owners December 15, 2025 20:03

BrianCurtis-NOAA previously approved these changes Dec 15, 2025

View reviewed changes

DavidHuber-NOAA previously approved these changes Dec 16, 2025

View reviewed changes

DavidHuber-NOAA added the GFS Change This PR, if merged, will change results for the GFS. label Dec 16, 2025

DavidHuber-NOAA requested review from CatherineThomas-NOAA and JessicaMeixner-NOAA December 16, 2025 14:33

emcbot added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Dec 16, 2025

Merge branch 'develop' into bugfix/global_cycle

3ac3b1d

emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Dec 16, 2025

DavidHuber-NOAA removed the CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules label Dec 16, 2025

emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Dec 16, 2025

DavidHuber-NOAA approved these changes Dec 17, 2025

View reviewed changes

Merge branch 'develop' into bugfix/global_cycle

b4773a7

emcbot added the CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 label Dec 17, 2025

DavidHuber-NOAA removed the CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed label Dec 17, 2025

emcbot added CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 labels Dec 17, 2025

DavidHuber-NOAA removed the CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 label Dec 17, 2025

emcbot added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Dec 17, 2025

This comment was marked as resolved.

Sign in to view

emcbot added the CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed label Dec 17, 2025

CatherineThomas-NOAA approved these changes Dec 17, 2025

View reviewed changes

DavidHuber-NOAA merged commit d095c83 into NOAA-EMC:develop Dec 18, 2025
6 checks passed

ClaraDraper-NOAA mentioned this pull request Dec 18, 2025

Turn off soil moisture relaxation. #4353

Merged

5 tasks

RussTreadon-NOAA mentioned this pull request Dec 26, 2025

global_cycle reports a fatal error on 06Z gfs cycles #4364

Closed

ClaraDraper-NOAA mentioned this pull request Jan 6, 2026

Identify impact of global_cycle time shift ClaraDraper-NOAA/task_tracker#47

Closed

ClaraDraper-NOAA mentioned this pull request Jan 14, 2026

Clean up sfcsub.F: remove unused code, comments, and developer tags ufs-community/ccpp-physics#343

Merged

Conversation

ClaraDraper-NOAA commented Dec 12, 2025 • edited by DavidHuber-NOAA Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Change characteristics

How has this been tested?

Checklist

Uh oh!

ClaraDraper-NOAA commented Dec 15, 2025

Uh oh!

ClaraDraper-NOAA commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

DavidHuber-NOAA commented Dec 16, 2025

Uh oh!

emcbot commented Dec 16, 2025

Uh oh!

emcbot commented Dec 16, 2025

Uh oh!

emcbot commented Dec 16, 2025

Uh oh!

RussTreadon-NOAA commented Dec 16, 2025

Uh oh!

ClaraDraper-NOAA commented Dec 16, 2025

Uh oh!

DavidHuber-NOAA commented Dec 17, 2025

Uh oh!

ClaraDraper-NOAA commented Dec 17, 2025

Uh oh!

DavidHuber-NOAA commented Dec 17, 2025

Uh oh!

DavidHuber-NOAA commented Dec 17, 2025

Uh oh!

This comment was marked as resolved.

CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

ClaraDraper-NOAA commented Dec 17, 2025

Uh oh!

DavidHuber-NOAA commented Dec 17, 2025

Uh oh!

DavidHuber-NOAA commented Dec 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ClaraDraper-NOAA commented Dec 12, 2025 •

edited by DavidHuber-NOAA

Loading

ClaraDraper-NOAA commented Dec 15, 2025 •

edited

Loading