Skip to content

Turn off soil moisture relaxation.#4353

Merged
JessicaMeixner-NOAA merged 1 commit intoNOAA-EMC:dev/gfs.v17from
ClaraDraper-NOAA:bugfix/globcyc_v17
Dec 18, 2025
Merged

Turn off soil moisture relaxation.#4353
JessicaMeixner-NOAA merged 1 commit intoNOAA-EMC:dev/gfs.v17from
ClaraDraper-NOAA:bugfix/globcyc_v17

Conversation

@ClaraDraper-NOAA
Copy link
Contributor

@ClaraDraper-NOAA ClaraDraper-NOAA commented Dec 18, 2025

Description

Following discussion with @CatherineThomas-NOAA, this PR corrects the soil relaxation bug in v17 retros, resolving issue #

In develop, this fix was included in a PR # which included an additional change to correct a long-standing error in the time input to global_cycle. The latter change has not been tested sufficiently for inclusion into v17 retros, so I've created this PR to merge in only the soil relaxation change to v17.

Type of change

  • [x ] Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES/NO (If YES, please indicate to which system(s))
    • [x ] GFS
    • GEFS
    • SFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    4 -->

How has this been tested?

Checklist

  • [x ] Any dependent changes have been merged and published
  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have documented my code, including function, input, and output descriptions
  • [ x] My changes generate no new warnings
  • [x ] New and existing tests pass with my changes
  • [x ] This change is covered by an existing CI test or a new one has been added
  • [ x] Any new scripts have been added to the .github/CODEOWNERS file with owners
  • [x ] I have made corresponding changes to the system documentation if necessary

@ClaraDraper-NOAA
Copy link
Contributor Author

Draft PR while I test it - very minor change though, so not expecting any issues.

@CatherineThomas-NOAA
Copy link
Contributor

cc @JessicaMeixner-NOAA @RuiyuSun

@CatherineThomas-NOAA
Copy link
Contributor

Changes look as expected. Waiting for @ClaraDraper-NOAA's quick check before approving.

@ClaraDraper-NOAA ClaraDraper-NOAA marked this pull request as ready for review December 18, 2025 16:17
@ClaraDraper-NOAA
Copy link
Contributor Author

Test has run successfully on URSA. Ready for final review and merge.

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 338f2ab into NOAA-EMC:dev/gfs.v17 Dec 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants