Skip to content

Fix two bugfixes to global_cycle.sh #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidHuber-NOAA merged 8 commits into from
Dec 18, 2025
Merged

Fix two bugfixes to global_cycle.sh #4327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
64f3aac
Changes to global_cycle, to turn off soil moisture relaxation and to
ClaraDraper-NOAA Dec 12, 2025
20f249c
export gcycle_date, and change piping for PGMOUT in global_cycle.sh to
ClaraDraper-NOAA Dec 15, 2025
3ac3b1d
Merge branch 'develop' into bugfix/global_cycle
DavidHuber-NOAA Dec 16, 2025
3e0102f
Corrected gcycle_date for enkf_sfc call.
ClaraDraper-NOAA Dec 16, 2025
ca3c379
Merge branch 'develop' into bugfix/global_cycle
ClaraDraper-NOAA Dec 16, 2025
a60ef21
Merge branch 'bugfix/global_cycle' of https://github.com/ClaraDraper-…
ClaraDraper-NOAA Dec 16, 2025
0dd5df8
remove comments.
ClaraDraper-NOAA Dec 16, 2025
b4773a7
Merge branch 'develop' into bugfix/global_cycle
DavidHuber-NOAA Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/scripts/exglobal_atmos_sfcanl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ fi
# Loop over the dates in the window to update the surface restarts
for hr in "${!gcycle_dates[@]}"; do

gcycle_date="${gcycle_dates[hr]}"
export gcycle_date="${gcycle_dates[hr]}"
FHR="${soilinc_fhrs[hr]}"
echo "Updating surface restarts for ${gcycle_date} ..."

Expand Down
4 changes: 4 additions & 0 deletions dev/scripts/exglobal_enkf_sfc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,8 @@ if [[ "${DOIAU}" == "YES" ]]; then

done # ensembles

export gcycle_date="${bPDY}${bcyc}"

"${CYCLESH}" && true
export err=$?
if [[ ${err} -ne 0 ]]; then
Expand Down Expand Up @@ -288,6 +290,8 @@ if [[ "${DOSFCANL_ENKF}" == "YES" ]]; then
fi
done

export gcycle_date="${PDY}${cyc}"

"${CYCLESH}" && true
export err=$?
if [[ ${err} -ne 0 ]]; then
Expand Down
12 changes: 6 additions & 6 deletions ush/global_cycle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ DELTSFC=${DELTSFC:-0}

LSOIL=${LSOIL:-4}
LSOIL_INCR=${LSOIL_INCR:-2}
FSMCL2=${FSMCL2:-60}
FSMCL2=${FSMCL2:-99999.}
FSLPL=${FSLPL:-99999.}
FSOTL=${FSOTL:-99999.}
FVETL=${FVETL:-99999.}
Expand Down Expand Up @@ -278,10 +278,10 @@ ln -fs "${FNSALC}" salclm
export PGM=${CYCLEXEC}
export pgm=${PGM}

iy=${PDY:0:4}
im=${PDY:4:2}
id=${PDY:6:2}
ih=${cyc}
iy=${gcycle_date:0:4}
im=${gcycle_date:4:2}
id=${gcycle_date:6:2}
ih=${gcycle_date:8:2}

export OMP_NUM_THREADS=${OMP_NUM_THREADS_CY:-${CYCLETHREAD:-1}}

Expand Down Expand Up @@ -340,7 +340,7 @@ cat << EOF > fort.37
/
EOF

${APRUNCY} "${CYCLEXEC}" 1> "${PGMOUT}" 2> "${PGMERR}"
${APRUNCY} "${CYCLEXEC}" 1>> "${PGMOUT}" 2>> "${PGMERR}"

export err=$?

Expand Down
Loading