Skip to content

Fix use of NSST in GCAFS#4299

Merged
DavidHuber-NOAA merged 23 commits intoNOAA-EMC:developfrom
CoryMartin-NOAA:bugfix/gcafs-nsst
Jan 5, 2026
Merged

Fix use of NSST in GCAFS#4299
DavidHuber-NOAA merged 23 commits intoNOAA-EMC:developfrom
CoryMartin-NOAA:bugfix/gcafs-nsst

Conversation

@CoryMartin-NOAA
Copy link
Contributor

Description

This PR fixes 2 bugs:

  1. GCAFS was naively using the NSST increment from GDAS, because the filename suggested it was an analysis and not an increment. A new utility is being added to GFS-Utils to calculate this instead of just using it directly
  2. Rename the files so that this mix up won't happen in the future

Resolves #4291

Note this will require a file addition to the tars stored on MSU HPC before those tests will pass successfully

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES
    • GFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

Built and tested on Ursa, would like a longer test to see if it fixes the observed problem

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@XuLi-NOAA XuLi-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments:

  1. Originally, the file dtfanl was named to represent the dela (increment) of Tf analysis). I agree it needs a better name to be consistent with others.
  2. The Tf analysis is generated through global_cycle, in which the Gaussian grid Tf analysis incement is intepolated to FV3 native grid and then added to the background (fitst guess) in global_cycle, which is a utility of UFS_UTILS.
  3. The SST and surface salinity alimatology are used in global_cycle to address some grids where no nearby water grids available from dtfanl and the newly generated ice.

@CoryMartin-NOAA
Copy link
Contributor Author

Thanks @XuLi-NOAA is the approach here: NOAA-EMC/gfs-utils#165 reasonable?

bbakernoaa
bbakernoaa previously approved these changes Dec 15, 2025
Copy link
Contributor

@bbakernoaa bbakernoaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After resolving the conflicts, I approve. This seems to produce reasonable results even after 30+days of cycling

@CoryMartin-NOAA
Copy link
Contributor Author

I think this PR is ready for final review and testing. Any changes needed for the pres_b archiving should go in a different PR.

@CoryMartin-NOAA
Copy link
Contributor Author

I will run the GCAFS C96_cycled test on Ursa to test and fetch the new files needed, then will copy to MSU and test there. If this happens before the PR is merged, I will re-activate the MSU CI, otherwise I will reactivate that in a future PR (it will require an update of the staged input tar ball)

Copy link
Contributor

@TravisElless-NOAA TravisElless-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I saw off the bat

@CoryMartin-NOAA
Copy link
Contributor Author

I've reverted the changes turning off the MSU CI tests. The Tref code runs on Orion and once the updated files have been staged, should pass the CI test.

@CoryMartin-NOAA CoryMartin-NOAA changed the title Fix use of NSST in GCAFS and rename NSST files Fix use of NSST in GCAFS Dec 31, 2025
Copy link
Contributor

@TravisElless-NOAA TravisElless-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are fine to me here. Approving pending testing and staging of the MSU files

@DavidHuber-NOAA
Copy link
Contributor

@CoryMartin-NOAA let me know if/when you need something staged in the glopara space on MSU.

@CoryMartin-NOAA
Copy link
Contributor Author

@DavidHuber-NOAA yes please, see #3806 (comment)

@TravisElless-NOAA
Copy link
Contributor

Since files have now been staged, will (attempt to) launch Hercules CI

@emcbot emcbot added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Jan 2, 2026
@CoryMartin-NOAA
Copy link
Contributor Author

Hercules CI passed. Anything else I need to do?

@DavidHuber-NOAA DavidHuber-NOAA merged commit bc6c292 into NOAA-EMC:develop Jan 5, 2026
5 checks passed
@TravisElless-NOAA TravisElless-NOAA mentioned this pull request Feb 5, 2026
13 tasks
DavidHuber-NOAA pushed a commit that referenced this pull request Feb 6, 2026
It was noted in #4299 that the NSST dtfanl files being produced by GSI
were really increment files. This PR renames all global workflow
variables from `DTFANL` to `DTFINC` and also renames the file within and
saved by the global workflow to `dtfinc.nc`.

  Resolves #4395 
  Resolves #4505
CatherineThomas-NOAA pushed a commit to CatherineThomas-NOAA/global-workflow that referenced this pull request Feb 9, 2026
It was noted in NOAA-EMC#4299 that the NSST dtfanl files being produced by GSI
were really increment files. This PR renames all global workflow
variables from `DTFANL` to `DTFINC` and also renames the file within and
saved by the global workflow to `dtfinc.nc`.

  Resolves NOAA-EMC#4395
  Resolves NOAA-EMC#4505
CatherineThomas-NOAA added a commit that referenced this pull request Feb 11, 2026
# Description

This PR merges #4523 and
its prerequisite PR
#4299 into the
dev/gfs.v17 branch. It changes the NSST output naming convention from
"analysis" to "increment" to better reflect what's actually in the file.
[PR#4523 ](#4523
adds the idx file creation for the master grib files.

Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
Co-authored-by: Travis Elless <113720457+TravisElless-NOAA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calculate dtf from tref differences for GCAFS

7 participants