Fix use of NSST in GCAFS#4299
Conversation
XuLi-NOAA
left a comment
There was a problem hiding this comment.
Comments:
- Originally, the file dtfanl was named to represent the dela (increment) of Tf analysis). I agree it needs a better name to be consistent with others.
- The Tf analysis is generated through global_cycle, in which the Gaussian grid Tf analysis incement is intepolated to FV3 native grid and then added to the background (fitst guess) in global_cycle, which is a utility of UFS_UTILS.
- The SST and surface salinity alimatology are used in global_cycle to address some grids where no nearby water grids available from dtfanl and the newly generated ice.
|
Thanks @XuLi-NOAA is the approach here: NOAA-EMC/gfs-utils#165 reasonable? |
|
I think this PR is ready for final review and testing. Any changes needed for the |
|
I will run the GCAFS C96_cycled test on Ursa to test and fetch the new files needed, then will copy to MSU and test there. If this happens before the PR is merged, I will re-activate the MSU CI, otherwise I will reactivate that in a future PR (it will require an update of the staged input tar ball) |
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
Only thing I saw off the bat
|
I've reverted the changes turning off the MSU CI tests. The Tref code runs on Orion and once the updated files have been staged, should pass the CI test. |
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
Things are fine to me here. Approving pending testing and staging of the MSU files
|
@CoryMartin-NOAA let me know if/when you need something staged in the glopara space on MSU. |
|
@DavidHuber-NOAA yes please, see #3806 (comment) |
|
Since files have now been staged, will (attempt to) launch Hercules CI |
|
Hercules CI passed. Anything else I need to do? |
It was noted in NOAA-EMC#4299 that the NSST dtfanl files being produced by GSI were really increment files. This PR renames all global workflow variables from `DTFANL` to `DTFINC` and also renames the file within and saved by the global workflow to `dtfinc.nc`. Resolves NOAA-EMC#4395 Resolves NOAA-EMC#4505
# Description This PR merges #4523 and its prerequisite PR #4299 into the dev/gfs.v17 branch. It changes the NSST output naming convention from "analysis" to "increment" to better reflect what's actually in the file. [PR#4523 ](#4523 adds the idx file creation for the master grib files. Co-authored-by: Cory Martin <cory.r.martin@noaa.gov> Co-authored-by: Travis Elless <113720457+TravisElless-NOAA@users.noreply.github.com>
Description
This PR fixes 2 bugs:
Resolves #4291
Note this will require a file addition to the tars stored on MSU HPC before those tests will pass successfully
Type of change
Change characteristics
How has this been tested?
Built and tested on Ursa, would like a longer test to see if it fixes the observed problem
Checklist