v17: Update NSST dtf file and master idx#4538
Merged
CatherineThomas-NOAA merged 2 commits intoNOAA-EMC:dev/gfs.v17from Feb 11, 2026
Merged
v17: Update NSST dtf file and master idx#4538CatherineThomas-NOAA merged 2 commits intoNOAA-EMC:dev/gfs.v17from
CatherineThomas-NOAA merged 2 commits intoNOAA-EMC:dev/gfs.v17from
Conversation
This fixes 2 bugs: 1) GCAFS was naively using the NSST increment from GDAS, because the filename suggested it was an analysis and not an increment. A new utility is being added to GFS-Utils to calculate this instead of just using it directly 2) Rename the files so that this mix up won't happen in the future
It was noted in NOAA-EMC#4299 that the NSST dtfanl files being produced by GSI were really increment files. This PR renames all global workflow variables from `DTFANL` to `DTFINC` and also renames the file within and saved by the global workflow to `dtfinc.nc`. Resolves NOAA-EMC#4395 Resolves NOAA-EMC#4505
Contributor
Author
|
WCOSS2 CI Tests All tests passed except for C48_S2SWA_gefs, C96_gcafs_cycled_noDA, and C96_gcafs_cycled. |
Contributor
Author
|
Gaea C6 CI Tests The same GEFS and GCAFS tests failed on Gaea as well, with all other tests passing. |
Contributor
Author
|
The v17 related tests passed on both machines. The only failures were in GEFS and GCAFS tests, which I believe is expected at this time for the I also ran the Taking out of draft. |
CatherineThomas-NOAA
requested review from
CoryMartin-NOAA,
DavidHuber-NOAA and
aerorahul
as code owners
Contributor
Author
Contributor
|
@CatherineThomas-NOAA - We should only be running -G for dev/gfsv17 -- the other tests do fail, and the only thing that we're worried about is GFS tests. |
CoryMartin-NOAA
approved these changes
Feb 10, 2026
JessicaMeixner-NOAA
approved these changes
Feb 10, 2026
DavidHuber-NOAA
approved these changes
Feb 10, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR merges #4523 and its prerequisite PR #4299 into the dev/gfs.v17 branch. It changes the NSST output naming convention from "analysis" to "increment" to better reflect what's actually in the file. PR#4523 also adds the idx file creation for the master grib files.
Type of change
Change characteristics
How has this been tested?
Ran generate_workflows.sh -G -E -S -C run on Cactus and Gaea-C6. Results as expected and shared in the comments.
Checklist