Skip to content

Rename dtfanl to dtfinc#4523

Merged
DavidHuber-NOAA merged 4 commits intoNOAA-EMC:developfrom
TravisElless-NOAA:feature/rename_dtfanl
Feb 6, 2026
Merged

Rename dtfanl to dtfinc#4523
DavidHuber-NOAA merged 4 commits intoNOAA-EMC:developfrom
TravisElless-NOAA:feature/rename_dtfanl

Conversation

@TravisElless-NOAA
Copy link
Contributor

@TravisElless-NOAA TravisElless-NOAA commented Feb 5, 2026

Description

It was noted in #4299 that the NSST dtfanl files being produced by GSI were really increment files. This PR renames all global workflow variables from DTFANL to DTFINC and also renames the file within and saved by the global workflow to dtfinc.nc.

Resolves #4395
Resolves #4505

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

4 different CI tests were run on Gaea. All tests completed and produced the same results as develop tests.
All tests can be found in: /gpfs/f6/drsa-precip3/world-shared/Travis.J.Elless/test

####################### C48mx500_hybAOWCDA_test2 #######################
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Feb 04 2026 20:50:10    Feb 04 2026 21:10:23
202103250000        Done    Feb 04 2026 20:50:10    Feb 05 2026 14:12:38
######################## C96C48_hybatmDA_test2 #########################
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Feb 04 2026 16:00:09    Feb 04 2026 16:20:13
202112210000        Done    Feb 04 2026 16:00:09    Feb 04 2026 17:39:10
202112210600        Done    Feb 04 2026 16:00:09    Feb 04 2026 18:00:09
202112211200        Done    Feb 04 2026 17:46:48    Feb 04 2026 18:50:10
###################### C96C48_hybatmsoilDA_test2 #######################
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202205150600        Done    Feb 04 2026 20:50:10    Feb 04 2026 21:15:23
202205151200        Done    Feb 04 2026 20:50:10    Feb 05 2026 14:13:17
202205151800        Done    Feb 04 2026 20:50:10    Feb 05 2026 15:05:10
######################## C96_gcafs_cycled_test1 ########################
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Feb 03 2026 19:55:10    Feb 03 2026 20:14:06
202112201800        Done    Feb 03 2026 19:55:10    Feb 03 2026 22:00:20
202112210000        Done    Feb 03 2026 19:55:10    Feb 03 2026 21:30:07

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Feb 5, 2026
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @TravisElless-NOAA

@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Feb 5, 2026
16 tasks
@DavidHuber-NOAA
Copy link
Contributor

Launching CI on C6.

@emcbot emcbot added CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 labels Feb 5, 2026
Copy link
Contributor

@WenMeng-NOAA WenMeng-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update for generating master index files looks good to me.

@emcbot emcbot added CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully and removed CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress labels Feb 6, 2026
@DavidHuber-NOAA DavidHuber-NOAA merged commit 00a31a7 into NOAA-EMC:develop Feb 6, 2026
9 checks passed
CatherineThomas-NOAA pushed a commit to CatherineThomas-NOAA/global-workflow that referenced this pull request Feb 9, 2026
It was noted in NOAA-EMC#4299 that the NSST dtfanl files being produced by GSI
were really increment files. This PR renames all global workflow
variables from `DTFANL` to `DTFINC` and also renames the file within and
saved by the global workflow to `dtfinc.nc`.

  Resolves NOAA-EMC#4395
  Resolves NOAA-EMC#4505
CatherineThomas-NOAA added a commit that referenced this pull request Feb 11, 2026
# Description

This PR merges #4523 and
its prerequisite PR
#4299 into the
dev/gfs.v17 branch. It changes the NSST output naming convention from
"analysis" to "increment" to better reflect what's actually in the file.
[PR#4523 ](#4523
adds the idx file creation for the master grib files.

Co-authored-by: Cory Martin <[email protected]>
Co-authored-by: Travis Elless <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFS master index files are missing NSST dtfanl file should actually be dtfinc

5 participants