Move j-jobs and ex-scripts into dev subdirectory#4259
Move j-jobs and ex-scripts into dev subdirectory#4259DavidHuber-NOAA merged 16 commits intoNOAA-EMC:developfrom
Conversation
CoryMartin-NOAA
requested review from
AndrewEichmann-NOAA,
BoCui-NOAA,
BrianCurtis-NOAA,
CatherineThomas-NOAA,
ChristopherHill-NOAA,
DavidHuber-NOAA,
DavidNew-NOAA,
EdwardSafford-NOAA,
EricSinsky-NOAA,
JesseMeng-NOAA,
JessicaMeixner-NOAA,
JiayiPeng-NOAA,
RussTreadon-NOAA,
WenMeng-NOAA,
aerorahul,
bbakernoaa,
guillaumevernieres,
jack-woollen,
jiaruidong2017 and
sbanihash
as code owners
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
All tasks in for e.g. https://github.com/CoryMartin-NOAA/global-workflow/blob/feature/move-jobs-scripts/dev/workflow/rocoto/gfs_tasks.py
need to know the new location of dev/job_cards/rocoto
|
@CoryMartin-NOAA : You are correct. This PR will break GDASApp atm_jjob ctests. This PR changes the paths to j-jobs. g-w CI jobs called from GDASAapp ctests may be OK since we use g-w create_experiment.py to set up the CI cases. |
|
Thanks @aerorahul I will move this back to draft, but I would like you and @DavidHuber-NOAA and others to flag issues like this if you can @RussTreadon-NOAA okay my AI friend can change these pretty quickly in GDASApp. I can work on that. |
|
@aerorahul @DavidHuber-NOAA any chance I'll be able to get grandfathered in on this shellnorms check for this PR? Or do we need to address these (is there a script to do so easily?) |
|
@TerrenceMcGuinness-NOAA are there CI things that need to be changed for this PR? @CoryMartin-NOAA No this is not a CI issue. No updates to the pipelines are required. |
https://github.com/NOAA-EMC/global-workflow/pull/4259/files#r2593914680 is the source of the error. |
…rtin-noaa/global-workflow into feature/move-jobs-scripts
Co-authored-by: Rahul Mahajan <[email protected]>
|
C96mx100_S2S FAILED on Gaeac6 (pipeline ID: 6129) In directory: Error Log Files: View Error Logs: (sfs_atmos_prod_mem000_f144.log) (sfs_ocean_prod_mem000_f120.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C48_S2SWA_gefs FAILED on Gaeac6 (pipeline ID: 6129) In directory: Error Log Files: View Error Logs: (gefs_wave_stat_f010-f014.log) (gefs_wavepostsbs_mem002_f113-f116.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96C48_hybatmsoilDA FAILED on Gaeac6 (pipeline ID: 6129) In directory: Error Log Files: View Error Logs: (enkfgdas_ecen000.log) (gdas_atmos_prod_f002.log) (gdas_atmos_prod_f009.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96C48_hybatmDA FAILED on Gaeac6 (pipeline ID: 6129) In directory: Error Log Files: View Error Logs: (gdas_atmanlupp.log) (gdas_atmos_prod_f001.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96C48mx500_S2SW_cyc_gfs FAILED on Gaeac6 (pipeline ID: 6129) In directory: Error Log Files: View Error Logs: (gfs_wavepostsbs_f015-f017.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
above looks to all be "libfabric" related |
|
I'll alert the helpdesk. They thought they had fixed all the libfabric issues. |
emcbot
added
CI-Ursa-Passed
|
All tests passed on WCOSS2 except the |
DavidHuber-NOAA
removed
the
CI-Gaeac6-Failed
|
@CoryMartin-NOAA Could you update the path for this script to Line 153 in a912381 |
DavidHuber-NOAA
added
CI-Wcoss2-Passed
|
All tests passed on WCOSS2. Merging. |
This moves `jobs/` to `dev/jobs`, `dev/jobs` to `dev/job_cards/rocoto` and `scripts` to `dev/scripts` (but symlinks the latter to the original location for now. This is in anticipation for T2O where we will only want to put in `jobs/` and `scripts/` the files needed for each application from the total global-workflow develop set.
# Description This has the workflow tests look for the j-jobs in the new dev/jobs location # Companion PRs NOAA-EMC/global-workflow#4259 # Issues Didn't create one # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !--> --------- Co-authored-by: Copilot <[email protected]>
# Description This has the workflow tests look for the j-jobs in the new dev/jobs location # Companion PRs NOAA-EMC/global-workflow#4259 # Issues Didn't create one # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !--> --------- Co-authored-by: Copilot <[email protected]>
12 participants
Description
This PR moves
jobs/todev/jobs,dev/jobstodev/job_cards/rocotoandscriptstodev/scripts(but symlinks the latter to the original location for now. This is in anticipation for T2O where we will only want to put injobs/andscripts/the files needed for each application from the total global-workflow develop set.Resolves #4257
Type of change
Change characteristics
How has this been tested?
Not yet tested
Checklist