Move pointers to workflow jobs#1984
Conversation
|
Needs to be merged after the Global-Workflow PR is merged |
There was a problem hiding this comment.
Pull Request Overview
This PR updates workflow test scripts to point to job files in their new location (${HOMEgfs}/dev/jobs/) instead of the old location (${HOMEgfs}/jobs/), aligning with the companion PR in the global-workflow repository.
- Updates path references from
${HOMEgfs}/jobs/to${HOMEgfs}/dev/jobs/across all test scripts - Maintains consistency between YAML configuration and direct execution paths
- Affects both atmospheric and aerosol analysis workflow tests
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/atm/global-workflow/jjob_var_run.sh | Updated path for JGLOBAL_ATM_ANALYSIS_VARIATIONAL job |
| test/atm/global-workflow/jjob_var_init.sh | Updated path for JGLOBAL_ATM_ANALYSIS_INITIALIZE job |
| test/atm/global-workflow/jjob_var_inc.sh | Updated path for JGLOBAL_ATM_ANALYSIS_FV3_INCREMENT job |
| test/atm/global-workflow/jjob_var_final.sh | Updated path for JGLOBAL_ATM_ANALYSIS_FINALIZE job |
| test/atm/global-workflow/jjob_ens_sol.sh | Updated path for JGLOBAL_ATMENS_ANALYSIS_SOL job |
| test/atm/global-workflow/jjob_ens_obs.sh | Updated path for JGLOBAL_ATMENS_ANALYSIS_OBS job |
| test/atm/global-workflow/jjob_ens_letkf.sh | Updated path for JGLOBAL_ATMENS_ANALYSIS_LETKF job |
| test/atm/global-workflow/jjob_ens_init_split.sh | Updated path for JGLOBAL_ATMENS_ANALYSIS_INITIALIZE job, but incorrect job name in else clause |
| test/atm/global-workflow/jjob_ens_init.sh | Updated path for JGLOBAL_ATMENS_ANALYSIS_INITIALIZE job, but incorrect job name in else clause |
| test/atm/global-workflow/jjob_ens_inc.sh | Updated path for JGLOBAL_ATMENS_ANALYSIS_FV3_INCREMENT job |
| test/atm/global-workflow/jjob_ens_final.sh | Updated path for JGLOBAL_ATMENS_ANALYSIS_FINALIZE job |
| test/aero/global-workflow/jjob_var_run.sh | Updated path for JGLOBAL_AERO_ANALYSIS_RUN job |
| test/aero/global-workflow/jjob_var_init.sh | Updated path for JGLOBAL_AERO_ANALYSIS_INITIALIZE job |
| test/aero/global-workflow/jjob_var_final.sh | Updated path for JGLOBAL_AERO_ANALYSIS_FINALIZE job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
These changes look correct.
We may find it necessary to change other files in GDASApp. We won't know for certain until we run the changes in this PR inside NOAA-EMC/global-workflow#4259.
NOTE: Once we merge these changes into GDASApp develop, select GDASApp ctests are broken until NOAA-EMC/global-workflow#4259 is in g-w develop. My preference is to not do this and sequence our PRs so that we maintain ctest fidelity.
|
agreed @RussTreadon-NOAA let's not merge this until after the global-workflow changes are made |
|
@RussTreadon-NOAA did #1998 make this redundant and thus can it be closed? |
|
@CoryMartin-NOAA : I failed to notice this PR yesterday. #1998 only updated paths for |
|
Ok thanks @RussTreadon-NOAA I'll resolve conflicts and request review |
|
Do we want to activate aero j-job tests in GDASApp? Currently |
|
Should probably keep them off for now until GCAFSv1.0 is frozen |
jianjunj
left a comment
There was a problem hiding this comment.
Good fix. (I wish I had known this one earlier today. :) )
# Description This has the workflow tests look for the j-jobs in the new dev/jobs location # Companion PRs NOAA-EMC/global-workflow#4259 # Issues Didn't create one # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !--> --------- Co-authored-by: Copilot <[email protected]>
Description
This has the workflow tests look for the j-jobs in the new dev/jobs location
Companion PRs
NOAA-EMC/global-workflow#4259
Issues
Didn't create one
Automated CI tests to run in Global Workflow