Skip to content

Move pointers to workflow jobs#1984

Merged
CoryMartin-NOAA merged 3 commits intodevelopfrom
feature/mv_jobs
Dec 10, 2025
Merged

Move pointers to workflow jobs#1984
CoryMartin-NOAA merged 3 commits intodevelopfrom
feature/mv_jobs

Conversation

@CoryMartin-NOAA
Copy link
Contributor

Description

This has the workflow tests look for the j-jobs in the new dev/jobs location

Companion PRs

NOAA-EMC/global-workflow#4259

Issues

Didn't create one

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmsnowDA
  • C96_gcafs_cycled
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@CoryMartin-NOAA CoryMartin-NOAA self-assigned this Nov 20, 2025
@CoryMartin-NOAA CoryMartin-NOAA marked this pull request as ready for review November 20, 2025 20:24
@CoryMartin-NOAA
Copy link
Contributor Author

Needs to be merged after the Global-Workflow PR is merged

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates workflow test scripts to point to job files in their new location (${HOMEgfs}/dev/jobs/) instead of the old location (${HOMEgfs}/jobs/), aligning with the companion PR in the global-workflow repository.

  • Updates path references from ${HOMEgfs}/jobs/ to ${HOMEgfs}/dev/jobs/ across all test scripts
  • Maintains consistency between YAML configuration and direct execution paths
  • Affects both atmospheric and aerosol analysis workflow tests

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/atm/global-workflow/jjob_var_run.sh Updated path for JGLOBAL_ATM_ANALYSIS_VARIATIONAL job
test/atm/global-workflow/jjob_var_init.sh Updated path for JGLOBAL_ATM_ANALYSIS_INITIALIZE job
test/atm/global-workflow/jjob_var_inc.sh Updated path for JGLOBAL_ATM_ANALYSIS_FV3_INCREMENT job
test/atm/global-workflow/jjob_var_final.sh Updated path for JGLOBAL_ATM_ANALYSIS_FINALIZE job
test/atm/global-workflow/jjob_ens_sol.sh Updated path for JGLOBAL_ATMENS_ANALYSIS_SOL job
test/atm/global-workflow/jjob_ens_obs.sh Updated path for JGLOBAL_ATMENS_ANALYSIS_OBS job
test/atm/global-workflow/jjob_ens_letkf.sh Updated path for JGLOBAL_ATMENS_ANALYSIS_LETKF job
test/atm/global-workflow/jjob_ens_init_split.sh Updated path for JGLOBAL_ATMENS_ANALYSIS_INITIALIZE job, but incorrect job name in else clause
test/atm/global-workflow/jjob_ens_init.sh Updated path for JGLOBAL_ATMENS_ANALYSIS_INITIALIZE job, but incorrect job name in else clause
test/atm/global-workflow/jjob_ens_inc.sh Updated path for JGLOBAL_ATMENS_ANALYSIS_FV3_INCREMENT job
test/atm/global-workflow/jjob_ens_final.sh Updated path for JGLOBAL_ATMENS_ANALYSIS_FINALIZE job
test/aero/global-workflow/jjob_var_run.sh Updated path for JGLOBAL_AERO_ANALYSIS_RUN job
test/aero/global-workflow/jjob_var_init.sh Updated path for JGLOBAL_AERO_ANALYSIS_INITIALIZE job
test/aero/global-workflow/jjob_var_final.sh Updated path for JGLOBAL_AERO_ANALYSIS_FINALIZE job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look correct.

We may find it necessary to change other files in GDASApp. We won't know for certain until we run the changes in this PR inside NOAA-EMC/global-workflow#4259.

NOTE: Once we merge these changes into GDASApp develop, select GDASApp ctests are broken until NOAA-EMC/global-workflow#4259 is in g-w develop. My preference is to not do this and sequence our PRs so that we maintain ctest fidelity.

@CoryMartin-NOAA
Copy link
Contributor Author

agreed @RussTreadon-NOAA let's not merge this until after the global-workflow changes are made

@CoryMartin-NOAA
Copy link
Contributor Author

@RussTreadon-NOAA did #1998 make this redundant and thus can it be closed?

@RussTreadon-NOAA
Copy link
Contributor

@CoryMartin-NOAA : I failed to notice this PR yesterday.

#1998 only updated paths for test/atm/global-workflow. I did not update paths for test/aero/global-workflow. The aero changes in this PR are still needed.

@CoryMartin-NOAA
Copy link
Contributor Author

Ok thanks @RussTreadon-NOAA I'll resolve conflicts and request review

@RussTreadon-NOAA
Copy link
Contributor

Do we want to activate aero j-job tests in GDASApp? Currently test/aero/CMakeLists.txt comments out inclusion of aero g-w tests.

@CoryMartin-NOAA
Copy link
Contributor Author

Should probably keep them off for now until GCAFSv1.0 is frozen

Copy link
Contributor

@jianjunj jianjunj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. (I wish I had known this one earlier today. :) )

@CoryMartin-NOAA CoryMartin-NOAA merged commit 181f964 into develop Dec 10, 2025
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/mv_jobs branch December 10, 2025 19:54
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
# Description

This has the workflow tests look for the j-jobs in the new dev/jobs
location

# Companion PRs

NOAA-EMC/global-workflow#4259

# Issues

Didn't create one

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] atm_jjob <!-- JEDI atm single cycle DA !-->
- [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !-->
- [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !-->
- [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->

---------

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants