Skip to content

chore(rtsp): tune buffer pool for 4K cameras #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janost merged 1 commit into from
Mar 19, 2026
Merged

chore(rtsp): tune buffer pool for 4K cameras #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/rtsp/factory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ fn send_to_sources(

fn bucket_size_for(n: usize) -> Option<usize> {
const MIN_BUCKET: usize = 256;
const MAX_BUCKET: usize = 1024 * 1024;
const MAX_BUCKET: usize = 4 * 1024 * 1024;
if n == 0 {
return Some(MIN_BUCKET);
}
Expand Down Expand Up @@ -465,6 +465,7 @@ fn acquire_pooled_buffer(
pool
});

log::trace!("Pooled buffer: needed={needed}, bucket={bucket}");
let mut buf = pool.acquire_buffer(None)?;
{
let buf_ref = buf.get_mut().unwrap();
Expand All @@ -480,6 +481,7 @@ fn acquire_pooled_buffer(
}
Ok(buf)
} else {
log::debug!("Frame size {needed} exceeds MAX_BUCKET, falling back to non-pooled allocation");
let mut buf = gstreamer::Buffer::with_size(needed)
.context("allocate large non-pooled buffer")?;
{
Expand Down
Loading