chore(rtsp): tune buffer pool for 4K cameras#4
Merged
Conversation
Increase MAX_BUCKET from 1MB to 4MB so 4K camera keyframes stay within the pooled allocation path. Add trace logging for bucket distribution and debug logging when frames exceed MAX_BUCKET and fall back to non-pooled allocation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracelogging for bucket distribution (needed vs bucket size)debuglogging when frames exceed MAX_BUCKET and fall back to non-pooled allocationContext: upstream PR QuantumEntangledAndy#373 introduced power-of-two buffer pooling but capped at 1MB. 4K H265 I-frames can exceed that, pushing them to per-frame allocation and losing the FD/fragmentation benefits.
Test plan
RUST_LOG=neolink::rtsp::factory=traceagainst a camera and verify bucket distribution logs appeardebugfallback messages for typical 1080p/4K streamswatch -n1 "ls -l /proc/<PID>/fd | wc -l"🤖 Generated with Claude Code