Version 1.1.0 by JosunLP · Pull Request #17 · JosunLP/sort-it-now

JosunLP · 2025-12-05T10:48:16Z

This pull request adds comprehensive Docker support and introduces configurable object rotations to the packing algorithm, along with related documentation and CI improvements. The most significant changes include a new Docker build pipeline, support for per-request and environment-based object rotations, expanded release packaging for macOS, and updates to the documentation to reflect these new features.

Docker Support and CI/CD Integration:

Added a production-ready Dockerfile for multi-stage builds, ensuring a minimal runtime image with non-root execution and environment variable configuration. (Dockerfile, DockerfileR1-R54)
Created .dockerignore to optimize Docker builds by excluding unnecessary files and directories. (.dockerignore, .dockerignoreR1-R23)
Introduced a GitHub Actions workflow (docker.yml) to automatically build and push multi-architecture Docker images to Docker Hub on new releases or manual triggers. (.github/workflows/docker.yml, .github/workflows/docker.ymlR1-R51)
Provided a detailed German setup guide for Docker Hub deployment, including secret configuration and troubleshooting. (DOCKER_SETUP.md, DOCKER_SETUP.mdR1-R120)

Release Packaging Improvements:

Extended release workflow to build and package binaries for both macOS ARM64 (Apple Silicon) and x86_64 (Intel), in addition to Linux and Windows. (.github/workflows/release.yml, [1] [2]
Improved packaging scripts to handle platform-specific SHA256 checksum generation. (.github/workflows/release.yml, .github/workflows/release.ymlR73-R77)
Updated documentation to reflect new macOS release targets and Docker image availability. (README.md, [1] [2]

Configurable Object Rotations:

Added an optional allow_rotations field to the packing API request, allowing clients to enable or disable 90° object rotations per request. (src/api.rs, [1] [2] [3] [4] [5]
Enabled global control of object rotations via the new SORT_IT_NOW_PACKING_ALLOW_ROTATIONS environment variable, with logic to override per request. (src/config.rs, [1] [2]
Updated documentation and example configs to describe rotation options and their usage. (README.md, [1] [2] [3] [4]

Documentation Updates:

Enhanced feature list and usage instructions in README.md to include object rotation controls (UI and API), Docker usage, and new release artifacts. (README.md, [1] [2] [3]
Clarified known limitations regarding object rotation and other algorithmic constraints. (README.md, README.mdL288-R330)

Miscellaneous Improvements:

Set explicit contents: read permissions in GitHub workflows for improved security. (.github/workflows/rust.yml, .github/workflows/rust.ymlR2-R3)

These changes collectively make the project easier to deploy, more flexible for users, and better documented for both end users and maintainers.

Housekeeping

Co-authored-by: JosunLP <[email protected]>

…e für nicht unterstützte macOS-Architekturen hinzu

* ✨ Füge Unterstützung für die Rotation von Objekten hinzu: Ermöglicht alternative Ausrichtungen während des Verpackungsprozesses und aktualisiert die Benutzeroberfläche zur Konfiguration. * Optimize rotation deduplication and standardize epsilon handling (#14) * Initial plan * Address PR review comments: optimize orientation deduplication and standardize epsilon values Co-authored-by: JosunLP <[email protected]> * Extract dimension hash scale factor to named constant and reduce overflow risk Co-authored-by: JosunLP <[email protected]> * Fix misleading comment about dimension hash scale factor Co-authored-by: JosunLP <[email protected]> * Remove unused dims_almost_equal function after optimization Co-authored-by: JosunLP <[email protected]> * Remove unnecessary blank line for code consistency Co-authored-by: JosunLP <[email protected]> * Add test coverage for orientation deduplication with equal dimensions Co-authored-by: JosunLP <[email protected]> * Add clarifying comments for O(n²) uniqueness checks in tests Co-authored-by: JosunLP <[email protected]> * Fix trailing whitespace and align frontend epsilon to backend precision Co-authored-by: JosunLP <[email protected]> * Update src/optimizer.rs Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]> --------- Signed-off-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> Co-authored-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: Copilot <[email protected]> * Update README.md Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]> * Move allow_rotations documentation to API endpoints section (#15) * Initial plan * Move allow_rotations documentation to API endpoints section Co-authored-by: JosunLP <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> --------- Signed-off-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Copilot <[email protected]>

* Initial plan * Add Docker deployment support with GitHub Actions workflow Co-authored-by: JosunLP <[email protected]> * Add Docker setup documentation and update Dockerfile to use latest Rust Co-authored-by: JosunLP <[email protected]> * Address code review feedback: pin Rust version and improve placeholders Co-authored-by: JosunLP <[email protected]> * Apply PR review feedback: security, caching, and documentation improvements Co-authored-by: JosunLP <[email protected]> * Apply second round of PR review feedback Co-authored-by: JosunLP <[email protected]> * Apply third round of PR review feedback Co-authored-by: JosunLP <[email protected]> * Apply fourth round of PR review feedback Co-authored-by: JosunLP <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]>

…n permissions (#16) Signed-off-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Copilot

Pull request overview

This pull request introduces comprehensive Docker support and configurable object rotations to the 3D packing algorithm, along with expanded platform support for macOS and enhanced documentation. The changes enable per-request rotation control, streamline deployment through Docker, and extend the release pipeline to cover both Apple Silicon and Intel Macs.

Added configurable 90° object rotations via API field allow_rotations and environment variable SORT_IT_NOW_PACKING_ALLOW_ROTATIONS
Implemented production-ready Docker support with multi-architecture images (linux/amd64, linux/arm64) and automated Docker Hub deployment
Extended release builds to include macOS ARM64 and x86_64 targets with proper auto-update support

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`Dockerfile`	Multi-stage build configuration with non-root user execution and security best practices
`.dockerignore`	Optimizes Docker build context by excluding unnecessary files
`.github/workflows/docker.yml`	Automated Docker image building and pushing to Docker Hub on releases
`DOCKER_SETUP.md`	Comprehensive German guide for Docker Hub deployment setup and troubleshooting
`.github/workflows/release.yml`	Extended to build and package macOS ARM64 and x86_64 binaries with proper SHA256 checksums
`.github/workflows/rust.yml`	Added explicit `contents: read` permissions for improved security
`src/optimizer.rs`	Implemented rotation logic with efficient deduplication, comprehensive tests, and orientation-aware placement
`src/config.rs`	Added boolean parser for `SORT_IT_NOW_PACKING_ALLOW_ROTATIONS` environment variable
`src/api.rs`	Added optional `allow_rotations` field to `PackRequest` with per-request override capability
`src/update.rs`	Extended auto-update system to support macOS (both ARM64 and x86_64 architectures)
`web/script.js`	Implemented frontend rotation logic with epsilon-based deduplication matching backend behavior
`web/index.html`	Added checkbox UI for rotation toggle with explanatory hint text
`README.md`	Updated documentation to describe Docker usage, macOS releases, rotation features, and configuration options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]>

Copilot · 2025-12-05T12:21:10Z

@JosunLP I've opened a new pull request, #18, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* Initial plan * Add conditional checks to Docker workflow to skip when secrets are not configured Co-authored-by: JosunLP <[email protected]> * Remove redundant ${{ }} wrappers from if conditionals in Docker workflow Co-authored-by: JosunLP <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]>

Copilot · 2025-12-08T08:12:52Z

@JosunLP I've opened a new pull request, #22, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Updated dependencies in Cargo.toml for axum, tokio, tower-http, rust-embed, tempfile, flate2, and zip. - Changed API route pattern from "/*path" to "{*path}" for better path matching. - Added #[allow(dead_code)] annotations to several functions in model.rs, geometry.rs, optimizer.rs to suppress warnings for unused code.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JosunLP · 2025-12-11T19:20:28Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2025-12-11T19:20:36Z

@JosunLP I've opened a new pull request, #23, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Address Docker review feedback - improve .dockerignore, add dev tag, clarify Dockerfile Co-authored-by: JosunLP <[email protected]> * Update .dockerignore Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]> --------- Signed-off-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> Co-authored-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: Copilot <[email protected]>

…vior (#21) * Initial plan * Add comprehensive test coverage for allow_rotations field Co-authored-by: JosunLP <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]>

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]>

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]>

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-12T08:28:02Z

@JosunLP I've opened a new pull request, #24, to work on those changes. Once the pull request is ready, I'll request review from you.

JosunLP and others added 10 commits October 29, 2025 22:29

Merge pull request #7 from JosunLP/dev

4e0ed93

Housekeeping

Initial plan

7ce7ce8

Add native macOS support for builds and releases

a5c909b

Co-authored-by: JosunLP <[email protected]>

Refactor: consolidate Unix installation logic for Linux and macOS

cca113d

Co-authored-by: JosunLP <[email protected]>

🐛 Korrigiere SHA256-Checksumme für Linux und macOS; füge Fehlerausgab…

f5e4143

…e für nicht unterstützte macOS-Architekturen hinzu

🐛 Verbessere Fehlerausgabe für nicht unterstützte macOS-Architekturen

f28bd5c

Merge branch 'copilot/add-macos-support-release' into dev

c3aba12

Potential fix for code scanning alert no. 1: Workflow does not contai…

3d4eaf8

…n permissions (#16) Signed-off-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

JosunLP self-assigned this Dec 5, 2025

Copilot AI review requested due to automatic review settings December 5, 2025 10:48

JosunLP added the enhancement New feature or request label Dec 5, 2025

github-actions Bot added documentation Improvements or additions to documentation rust config web labels Dec 5, 2025

Copilot started reviewing on behalf of JosunLP December 5, 2025 10:48 View session

JosunLP added this to the 1.1.0 milestone Dec 5, 2025

Copilot finished reviewing on behalf of JosunLP December 5, 2025 10:52

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Comment thread .github/workflows/docker.yml

Comment thread src/api.rs Outdated

Update src/api.rs

4d3f253

Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]>

Copilot AI review requested due to automatic review settings December 5, 2025 12:20

Copilot started reviewing on behalf of JosunLP December 5, 2025 12:20 View session

Copilot AI mentioned this pull request Dec 5, 2025

Add conditional checks to Docker workflow for missing secrets #18

Merged

6 tasks

Copilot finished reviewing on behalf of JosunLP December 5, 2025 12:24

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Comment thread src/optimizer.rs

Comment thread src/config.rs

Comment thread README.md

Comment thread README.md

JosunLP requested a review from Copilot December 5, 2025 12:47

Copilot AI mentioned this pull request Dec 8, 2025

No changes needed - review comments already addressed in PR #20 #22

Closed

JosunLP requested a review from Copilot December 8, 2025 08:32

Copilot started reviewing on behalf of JosunLP December 8, 2025 08:32 View session

Copilot AI reviewed Dec 8, 2025

View reviewed changes

JosunLP added 2 commits December 11, 2025 20:05

fmt

fc9635f

Copilot AI review requested due to automatic review settings December 11, 2025 19:13

Copilot started reviewing on behalf of JosunLP December 11, 2025 19:14 View session

Update version to 1.1.0 and enhance Docker setup documentation

95ba14b

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Comment thread src/api.rs

Comment thread .dockerignore Outdated

Comment thread .github/workflows/docker.yml

Comment thread Dockerfile

Copilot AI mentioned this pull request Dec 11, 2025

Refine Docker configuration and clarify axum 0.8 route syntax #23

Merged

Copilot AI and others added 2 commits December 12, 2025 09:03

Copilot AI review requested due to automatic review settings December 12, 2025 08:04

Copilot started reviewing on behalf of JosunLP December 12, 2025 08:04 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

Comment thread CHANGELOG Outdated

Update CHANGELOG

fee94cd

Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]>

Copilot AI review requested due to automatic review settings December 12, 2025 08:13

Copilot started reviewing on behalf of JosunLP December 12, 2025 08:14 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

Comment thread CHANGELOG Outdated

Update CHANGELOG

7bb3420

Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]>

Copilot AI review requested due to automatic review settings December 12, 2025 08:19

Copilot started reviewing on behalf of JosunLP December 12, 2025 08:20 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

Comment thread Cargo.toml

Copilot AI mentioned this pull request Dec 12, 2025

[WIP] Update database based on feedback for version 1.1.0 #24

Closed

JosunLP merged commit 69903ab into main Dec 12, 2025
18 checks passed

Uh oh!

Conversation

JosunLP commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Dec 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JosunLP commented Dec 11, 2025

Uh oh!

Copilot AI commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI commented Dec 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants