Add conditional checks to Docker workflow for missing secrets#18
Merged
Conversation
Merged
…t configured Co-authored-by: JosunLP <[email protected]>
Copilot
AI
changed the title
[WIP] WIP to address feedback from PR #17 for version 1.1.0
Add conditional checks to Docker workflow for missing secrets
Dec 5, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds conditional checks to the Docker workflow to prevent failures when DOCKER_USERNAME or DOCKER_PASSWORD secrets are not configured, which is particularly useful for manual workflow dispatches in environments where Docker Hub publishing isn't set up.
Key changes:
- Added
ifconditionals to three Docker-related steps (login, metadata extraction, build/push) - All conditionals check for the presence of both
DOCKER_USERNAMEandDOCKER_PASSWORDsecrets - Steps now skip gracefully instead of failing when secrets are unavailable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: JosunLP <[email protected]>
Contributor
Author
Applied the changes from the review feedback. Removed the redundant Changes made in commit 8c4a05b. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JosunLP
added a commit
that referenced
this pull request
Dec 12, 2025
* Initial plan * Add native macOS support for builds and releases Co-authored-by: JosunLP <[email protected]> * Refactor: consolidate Unix installation logic for Linux and macOS Co-authored-by: JosunLP <[email protected]> * 🐛 Korrigiere SHA256-Checksumme für Linux und macOS; füge Fehlerausgabe für nicht unterstützte macOS-Architekturen hinzu * 🐛 Verbessere Fehlerausgabe für nicht unterstützte macOS-Architekturen * Feature: Rotation (#11) * ✨ Füge Unterstützung für die Rotation von Objekten hinzu: Ermöglicht alternative Ausrichtungen während des Verpackungsprozesses und aktualisiert die Benutzeroberfläche zur Konfiguration. * Optimize rotation deduplication and standardize epsilon handling (#14) * Initial plan * Address PR review comments: optimize orientation deduplication and standardize epsilon values Co-authored-by: JosunLP <[email protected]> * Extract dimension hash scale factor to named constant and reduce overflow risk Co-authored-by: JosunLP <[email protected]> * Fix misleading comment about dimension hash scale factor Co-authored-by: JosunLP <[email protected]> * Remove unused dims_almost_equal function after optimization Co-authored-by: JosunLP <[email protected]> * Remove unnecessary blank line for code consistency Co-authored-by: JosunLP <[email protected]> * Add test coverage for orientation deduplication with equal dimensions Co-authored-by: JosunLP <[email protected]> * Add clarifying comments for O(n²) uniqueness checks in tests Co-authored-by: JosunLP <[email protected]> * Fix trailing whitespace and align frontend epsilon to backend precision Co-authored-by: JosunLP <[email protected]> * Update src/optimizer.rs Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]> --------- Signed-off-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> Co-authored-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: Copilot <[email protected]> * Update README.md Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]> * Move allow_rotations documentation to API endpoints section (#15) * Initial plan * Move allow_rotations documentation to API endpoints section Co-authored-by: JosunLP <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> --------- Signed-off-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Copilot <[email protected]> * Add Docker deployment target with automated Docker Hub publishing (#13) * Initial plan * Add Docker deployment support with GitHub Actions workflow Co-authored-by: JosunLP <[email protected]> * Add Docker setup documentation and update Dockerfile to use latest Rust Co-authored-by: JosunLP <[email protected]> * Address code review feedback: pin Rust version and improve placeholders Co-authored-by: JosunLP <[email protected]> * Apply PR review feedback: security, caching, and documentation improvements Co-authored-by: JosunLP <[email protected]> * Apply second round of PR review feedback Co-authored-by: JosunLP <[email protected]> * Apply third round of PR review feedback Co-authored-by: JosunLP <[email protected]> * Apply fourth round of PR review feedback Co-authored-by: JosunLP <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> * Potential fix for code scanning alert no. 1: Workflow does not contain permissions (#16) Signed-off-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Update src/api.rs Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]> * Add conditional checks to Docker workflow for missing secrets (#18) * Initial plan * Add conditional checks to Docker workflow to skip when secrets are not configured Co-authored-by: JosunLP <[email protected]> * Remove redundant ${{ }} wrappers from if conditionals in Docker workflow Co-authored-by: JosunLP <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> * Revert invalid secret conditionals in Docker workflow (#19) * Initial plan * Revert invalid secret conditionals in Docker workflow Co-authored-by: JosunLP <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> * Add unit tests for parse_bool and clarify allow_rotations API fallback (#20) * Initial plan * Add unit tests for parse_bool and clarify allow_rotations fallback behavior Co-authored-by: JosunLP <[email protected]> * Remove trailing whitespace from blank comment lines in test code Co-authored-by: JosunLP <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> * fmt * Update dependencies and improve API route handling - Updated dependencies in Cargo.toml for axum, tokio, tower-http, rust-embed, tempfile, flate2, and zip. - Changed API route pattern from "/*path" to "{*path}" for better path matching. - Added #[allow(dead_code)] annotations to several functions in model.rs, geometry.rs, optimizer.rs to suppress warnings for unused code. * Update version to 1.1.0 and enhance Docker setup documentation * Refine Docker configuration and clarify axum 0.8 route syntax (#23) * Initial plan * Address Docker review feedback - improve .dockerignore, add dev tag, clarify Dockerfile Co-authored-by: JosunLP <[email protected]> * Update .dockerignore Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]> --------- Signed-off-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> Co-authored-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: Copilot <[email protected]> * Add test coverage for allow_rotations field parsing and override behavior (#21) * Initial plan * Add comprehensive test coverage for allow_rotations field Co-authored-by: JosunLP <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]> * Update CHANGELOG Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]> * Update CHANGELOG Co-authored-by: Copilot <[email protected]> Signed-off-by: Jonas Pfalzgraf <[email protected]> --------- Signed-off-by: Jonas Pfalzgraf <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.