No changes needed - review comments already addressed in PR #20#22
Closed
Copilot wants to merge 1 commit into
Closed
No changes needed - review comments already addressed in PR #20#22Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Merged
Copilot
AI
changed the title
[WIP] Add Docker support and configurable object rotations
No changes needed - review comments already addressed in PR #20
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review thread 3550269357 requested test coverage for
parse_booland clarification ofallow_rotationsfallback behavior. Both items were already implemented in PR #20 (commit 77f1116) and merged to dev.Changes already in place:
parse_boolinsrc/config.rscovering true/false values, case insensitivity, whitespace handling, and invalid inputsREADME.mdline 149 to specify thatallow_rotationsfalls back toSORT_IT_NOW_PACKING_ALLOW_ROTATIONSenvironment variable (default: false) rather than vague "Umgebungsvariable bzw. UI-Schalter"All 19 tests pass including the three new
parse_booltest cases.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.