Skip to content

Conversation

@yhabteab
Copy link
Member

Fail to parse "type":"unknown" and "severity":"none" instead of parsing them as event.TypeUnknown and event.SeverityNone.

@yhabteab yhabteab requested a review from julianbrost October 28, 2025 16:23
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Oct 28, 2025
@yhabteab yhabteab added bug Something isn't working and removed cla/signed CLA is signed by all contributors of a PR labels Oct 28, 2025
@yhabteab yhabteab added this to the 0.8.0 milestone Oct 28, 2025
@yhabteab yhabteab requested review from oxzi and removed request for julianbrost November 3, 2025 13:27
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Due to the iota type mixed with the obscured type_string.go file, I needed a moment to understand the implications. Especially as _Type_index contains an entry for typeMax, internal. However, due to range typeMax, the ParseType function cannot parse "internal" to typemax.

const _Type_name = "unknownacknowledgement-clearedacknowledgement-setcustomdowntime-enddowntime-removeddowntime-startflapping-endflapping-startincident-agemutestateunmuteinternal"

@oxzi oxzi merged commit 40fe8fc into main Nov 6, 2025
15 checks passed
@oxzi oxzi deleted the fix-parse-sev-and-type branch November 6, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants