Fail to parse unknown & none strings for event.Type/Severity types

Author: yhabteab

notifications/event/severity.go

@@ -97,7 +97,7 @@ func (s Severity) Value() (driver.Value, error) {
 // If the string does not match any known severity, it returns an error indicating the unknown severity.
 func ParseSeverity(name string) (Severity, error) {
 	for s := range severityMax {
-		if s.String() == name {
+		if s != SeverityNone && s.String() == name {
 			return s, nil
 		}
 	}

notifications/event/severity_test.go

@@ -49,6 +49,7 @@ func TestSeverity(t *testing.T) {
 			{Name: "Alert", Expected: SeverityAlert, Data: `"alert"`, Error: nil},
 			{Name: "Emerg", Expected: SeverityEmerg, Data: `"emerg"`, Error: nil},
 			{Name: "Invalid", Expected: SeverityNone, Data: `"invalid"`, Error: testutils.ErrorContains(`unknown severity "invalid"`)},
+			{Name: "Invalid None", Expected: SeverityNone, Data: `"none"`, Error: testutils.ErrorContains(`unknown severity "none"`)},
 		}
 
 		for _, tt := range testData {

notifications/event/type.go

@@ -100,7 +100,7 @@ func (t Type) Value() (driver.Value, error) {
 // If the string does not match any known type, it returns an error indicating the unknown type.
 func ParseType(s string) (Type, error) {
 	for t := range typeMax {
-		if s == t.String() {
+		if t != TypeUnknown && s == t.String() {
 			return t, nil
 		}
 	}

notifications/event/type_test.go

@@ -39,6 +39,7 @@ func TestType(t *testing.T) {
 			{Name: "Unmute", Expected: TypeUnmute, Data: `"unmute"`, Error: nil},
 			{Name: "DowntimeStart", Expected: TypeDowntimeStart, Data: `"downtime-start"`, Error: nil},
 			{Name: "Invalid", Expected: TypeUnknown, Data: `"invalid"`, Error: testutils.ErrorContains(`unknown type "invalid"`)},
+			{Name: "Invalid Unknown", Expected: TypeUnknown, Data: `"unknown"`, Error: testutils.ErrorContains(`unknown type "unknown"`)},
 		}
 
 		for _, tt := range testData {