Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion notifications/event/severity.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ func (s Severity) Value() (driver.Value, error) {
// If the string does not match any known severity, it returns an error indicating the unknown severity.
func ParseSeverity(name string) (Severity, error) {
for s := range severityMax {
if s.String() == name {
if s != SeverityNone && s.String() == name {
return s, nil
}
}
Expand Down
1 change: 1 addition & 0 deletions notifications/event/severity_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func TestSeverity(t *testing.T) {
{Name: "Alert", Expected: SeverityAlert, Data: `"alert"`, Error: nil},
{Name: "Emerg", Expected: SeverityEmerg, Data: `"emerg"`, Error: nil},
{Name: "Invalid", Expected: SeverityNone, Data: `"invalid"`, Error: testutils.ErrorContains(`unknown severity "invalid"`)},
{Name: "Invalid None", Expected: SeverityNone, Data: `"none"`, Error: testutils.ErrorContains(`unknown severity "none"`)},
}

for _, tt := range testData {
Expand Down
2 changes: 1 addition & 1 deletion notifications/event/type.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func (t Type) Value() (driver.Value, error) {
// If the string does not match any known type, it returns an error indicating the unknown type.
func ParseType(s string) (Type, error) {
for t := range typeMax {
if s == t.String() {
if t != TypeUnknown && s == t.String() {
return t, nil
}
}
Expand Down
1 change: 1 addition & 0 deletions notifications/event/type_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ func TestType(t *testing.T) {
{Name: "Unmute", Expected: TypeUnmute, Data: `"unmute"`, Error: nil},
{Name: "DowntimeStart", Expected: TypeDowntimeStart, Data: `"downtime-start"`, Error: nil},
{Name: "Invalid", Expected: TypeUnknown, Data: `"invalid"`, Error: testutils.ErrorContains(`unknown type "invalid"`)},
{Name: "Invalid Unknown", Expected: TypeUnknown, Data: `"unknown"`, Error: testutils.ErrorContains(`unknown type "unknown"`)},
}

for _, tt := range testData {
Expand Down
Loading