vscode_extension cleanup: downcase extension names before comparison while evaluating for cleanup #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…while evaluating for cleanup.
…reating from scratch) an incorrect extension name (The extension as named by their author should retain case)
…an extension is already installed
MikeMcQuaid
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Thanks @vraravam, really great work so far! A few thoughts on some tweaks here.
MikeMcQuaid
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @vraravam!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1302 in a consistent manner such that cleanup doesn't uninstall if the case mismatch occurs