vscode_extension_installer: do case-insensitive matching to check if …

…an extension is already installed
Homebrew · Feb 9, 2024 · 101c7ee · 101c7ee
1 parent af668bc
commit 101c7ee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/bundle/vscode_extension_installer.rb b/lib/bundle/vscode_extension_installer.rb
@@ -38,7 +38,7 @@ def install(name, preinstall: true, no_upgrade: false, verbose: false, force: fa
     end
 
     def extension_installed?(name)
-      installed_extensions.include? name
+      installed_extensions.include? name.downcase
     end
 
     def installed_extensions

diff --git a/spec/bundle/vscode_extension_installer_spec.rb b/spec/bundle/vscode_extension_installer_spec.rb
@@ -27,9 +27,9 @@
         allow(described_class).to receive(:installed_extensions).and_return(["foo"])
       end
 
-      it "skips" do
+      it "skips ignoring case" do
         expect(Bundle).not_to receive(:system)
-        expect(described_class.preinstall("foo")).to be(false)
+        expect(described_class.preinstall("Foo")).to be(false)
       end
     end