vscode_extension cleanup: downcase extension names before comparison while evaluating for cleanup

lib/bundle/commands/cleanup.rb

@@ -143,7 +143,7 @@ def taps_to_untap(global: false, file: nil)
 
       def vscode_extensions_to_uninstall(global: false, file: nil)
         @dsl ||= Bundle::Dsl.new(Brewfile.read(global: global, file: file))
-        kept_extensions = @dsl.entries.select { |e| e.type == :vscode }.map(&:name)
+        kept_extensions = @dsl.entries.select { |e| e.type == :vscode }.map { |x| x.name.downcase }
 
         # To provide a graceful migration from `Brewfile`s that don't yet or
         # don't want to use `vscode`: don't remove any extensions if we don't

lib/bundle/vscode_extension_installer.rb

@@ -38,7 +38,7 @@ def install(name, preinstall: true, no_upgrade: false, verbose: false, force: fa
     end
 
     def extension_installed?(name)
-      installed_extensions.include? name
+      installed_extensions.include? name.downcase
     end
 
     def installed_extensions

spec/bundle/commands/cleanup_command_spec.rb

@@ -21,7 +21,7 @@
         brew 'hasbuilddependency1'
         brew 'hasbuilddependency2'
         mas 'appstoreapp1', id: 1
-        vscode 'vscodeextension1'
+        vscode 'VsCodeExtension1'
       EOS
     end
 
@@ -76,6 +76,11 @@
       allow(Bundle::VscodeExtensionDumper).to receive(:extensions).and_return(%w[z])
       expect(described_class.vscode_extensions_to_uninstall).to eql(%w[z])
     end
+
+    it "computes which VSCode extensions to uninstall irrespective of case of the extension name" do
+      allow(Bundle::VscodeExtensionDumper).to receive(:extensions).and_return(%w[z vscodeextension1])
+      expect(described_class.vscode_extensions_to_uninstall).to eql(%w[z])
+    end
   end
 
   context "when there are no formulae to uninstall and no taps to untap" do

spec/bundle/vscode_extension_installer_spec.rb

@@ -31,6 +31,11 @@
         expect(Bundle).not_to receive(:system)
         expect(described_class.preinstall("foo")).to be(false)
       end
+
+      it "skips ignoring case" do
+        expect(Bundle).not_to receive(:system)
+        expect(described_class.preinstall("Foo")).to be(false)
+      end
     end
 
     context "when app is not installed" do