More balance settings and GT Ore integration by Minepolz320 · Pull Request #36 · GTNewHorizons/twilightforest

Minepolz320 · 2024-01-14T17:23:32Z

-Ability to adjust the density of ore in stalactites
-Ability to disable certain ore in stalactites
-Ability to replace the type and ore in stalactites using ore metadata from GT

-Ability to customize the frequency of dungeon generation and landscape features

I immediately apologize for the low quality of the code
I can’t decide what to do:
it’s better to add the required method to the gregtech api or just use reflection
however, that’s why I opened it as a Draft

50%

Dream-Master · 2024-01-14T22:35:13Z

Make a config that we can add every gt ore not only this one you hard coded @Minepolz320

Minepolz320 · 2024-01-15T06:34:19Z

@Dream-Master yes, you can simply specify a different ore meta for a specific stalactite

gt_oremapping {
I:GT_coalOreMeta=535
I:GT_diamondOreMeta=500
I:GT_emeraldOreMeta=501
I:GT_goldOreMeta=86
I:GT_ironOreMeta=32
I:GT_lapisOreMeta=526
I:GT_redstoneOreMeta=810
}

Caedis · 2024-01-16T19:02:34Z

I would prefer if this was handled in GT and TF exposes an API that can be called

Minepolz320 · 2024-01-17T09:42:46Z

@Caedis Yes, but on the other hand, you don’t need a dependency to build a mod for such a minor change

I myself can’t decide whether it’s worth writing an api in the greg

YannickMG · 2024-01-27T23:11:13Z

We really shouldn't be using reflection for new code unless we have to.

Minepolz320 · 2024-01-28T09:25:38Z

@YannickMG unfortunately I can’t rewrite the code now, maybe later or I can cancel the request for now or just mark it as a draft

Minepolz320 · 2024-01-29T15:47:11Z

It even seems to work with the non-GTNH version of gregtech

Minepolz320 · 2024-01-31T13:45:27Z

Up?

YannickMG · 2024-01-31T15:03:31Z

Will be reviewing this evening.

YannickMG

Overall great and very welcome addition! I've made a few comments and suggestions.

Also, while this is in no way a blocker, I will mention that while we're adding the ability to replace TF ores I wonder why we're only looking at GT5U integration. For instance GT++ has Koboldite which it would be very nice to use here. If you want to make your solution more generic I suggest you simply expose an API that accepts a functional interface for the signature void setBlock(World world, int x, int y, int z, Block block) and let the caller decide exactly what ore block they want to place down. In that case integration with GT would be done in code in NewHorizonsCoreMod.

YannickMG · 2024-01-31T23:29:00Z

src/main/java/twilightforest/TFFeature.java

@@ -378,6 +378,15 @@ public static TFFeature generateFeatureForOldMapGen(int chunkX, int chunkZ, Worl
    }

    public static TFFeature generateFeatureFor1Point7(int chunkX, int chunkZ, World world) {


It appears this function isn't only used when generating a feature (as its name would suggest) but also when looking up which feature should exist in a given region.

Changing the configurated change post-worldgen affects functionality that check against existing features such as the magic map.

Is this intended? If so you might want to document the caveat that this config isn't meant to be modified on an existing world.

yes, definitely need a warning, I was worried that this would happen

YannickMG · 2024-01-31T23:35:52Z

src/main/java/twilightforest/biomes/TFBiomeDecorator.java

-            if (ry < 75) {
-                TFGenerator rf = randomFeature(randomGenerator);
-                rf.generate(currentWorld, randomGenerator, rx, ry, rz);
+        // now with chance


The "now" part of "now with chance" isn't going to be very helpful to future readers of the code, for which that comment will always have been there.

If the intent of the comment is to indicate that there's a chance of the feature not happening then you might want to encode that knowledge about the code's intent into a well named function instead.

YannickMG · 2024-01-31T23:42:12Z

src/main/java/twilightforest/world/TFGenCaveStalactite.java

+    // Greg?
+    public boolean doOreGen;
+


The // Greg? comment appears to be misleading since this can be used without GregTech. Also you should generally not expose fields publicly so this should be private.

YannickMG · 2024-01-31T23:42:34Z

src/main/java/twilightforest/gt_integration/GT_OrePlacer.java

+package twilightforest.gt_integration;
+
+import net.minecraft.block.Block;
+import net.minecraft.init.Blocks;
+import net.minecraft.world.World;
+
+import gregtech.common.blocks.GT_TileEntity_Ores;
+import twilightforest.TwilightForestMod;
+
+public class GT_OrePlacer {
+
+    public int getMappedGTMetaForOre(Block mOre) {


getMappedGTMetaForOre should be private, and if you remove GT_Integration_Utils::getOrePlacer then all of GT_OrePlacer can be package private instead of public to hide your implementation details.

YannickMG · 2024-01-31T23:42:51Z

src/main/java/twilightforest/gt_integration/GT_Integration_Utils.java

+package twilightforest.gt_integration;
+
+import net.minecraft.block.Block;
+import net.minecraft.world.World;
+
+public class GT_Integration_Utils {
+
+    static GT_OrePlacer orePlacer;
+
+    public static void init() {
+        // Create worker obj
+        orePlacer = new GT_OrePlacer();
+
+    }
+
+    public static boolean isInit() {
+        return orePlacer != null;
+    }
+
+    public static boolean doPlaceGTOre(World aWorld, int aX, int aY, int aZ, Block mcOreBlock) {
+        if (!isInit()) {
+            return false;
+        }
+        return orePlacer.placeGTOre(aWorld, aX, aY, aZ, mcOreBlock);
+    }
+
+    public static GT_OrePlacer getOrePlacer() {
+        return orePlacer;
+    }
+
+}


You should reduce the visibility of this class's members.

orePlacer and isInit can be private, getOrePlacer is not used and should be removed (or used).

YannickMG · 2024-01-31T23:43:09Z

src/main/java/twilightforest/biomes/TFBiomeDecorator.java

+        if (TFFeature.getRandom(randomGenerator, TwilightForestMod.minorFeatureGenChance)) {
+            if (randomGenerator.nextInt(6) == 0) {
+                int rx = chunk_X + randomGenerator.nextInt(16) + 8;
+                int rz = chunk_Z + randomGenerator.nextInt(16) + 8;
+                int ry = currentWorld.getHeightValue(rx, rz);
+                if (ry < 75) {
+                    TFGenerator rf = randomFeature(randomGenerator);
+                    rf.generate(currentWorld, randomGenerator, rx, ry, rz);
+                }


This new minorFeatureGenChance config option now compounds with an existing 1 in 7 chance of generating a minor feature. This makes the config option a bit misleading and limits our ability to do things such as making minor features more common.

Would it be possible to combine these random chances, such as by using 1/7 (~14.25%) as the default value of the config option?

yes, I think it’s logical to combine and leave the default 14% in the config

Minepolz320 · 2024-02-01T09:48:36Z

@YannickMG Tanks for amazing review
I'll try to fix everything

Minepolz320 · 2024-02-01T10:19:45Z

Overall great and very welcome addition! I've made a few comments and suggestions.

Also, while this is in no way a blocker, I will mention that while we're adding the ability to replace TF ores I wonder why we're only looking at GT5U integration. For instance GT++ has Koboldite which it would be very nice to use here. If you want to make your solution more generic I suggest you simply expose an API that accepts a functional interface for the signature void setBlock(World world, int x, int y, int z, Block block) and let the caller decide exactly what ore block they want to place down. In that case integration with GT would be done in code in NewHorizonsCoreMod.

ok i try to do this and make it possible to switch the mode in the config

сan i look some examples where is this done, for example in our project

boubou19 · 2024-03-10T21:41:21Z

superseded by #50

Minepolz320 added 2 commits January 14, 2024 22:14

More balance settings

b8ef1d3

tweaks

e6bffc1

Small ore and growstone fix

0af5478

Minepolz320 marked this pull request as ready for review January 16, 2024 08:39

Dream-Master requested a review from a team January 16, 2024 17:14

Minepolz320 mentioned this pull request Jan 28, 2024

add setOreBlock() to API GTNewHorizons/GT5-Unofficial#2480

Closed

Minepolz320 added 2 commits January 29, 2024 20:35

Change to direct call

a099f7c

Deps and BS

0b62035

Minepolz320 and others added 3 commits January 30, 2024 15:56

code reorganization

60cce95

compileOnly

11d94a2

Update .gitignore

5dd9b5b

YannickMG self-requested a review January 31, 2024 23:07

YannickMG reviewed Jan 31, 2024

View reviewed changes

Minepolz320 and others added 3 commits February 4, 2024 16:21

Rev Code rework

c4c3d00

Merge branch 'master' of https://github.com/Minepolz320/twilightforest

967a0eb

Merge branch 'master' into master

a8bc6e4

This was referenced Feb 24, 2024

Adds stalactite ore placing override API #41

Draft

Various additions #44

Merged

boubou19 mentioned this pull request Mar 10, 2024

todo list for 2.6.0 GTNewHorizons/GT-New-Horizons-Modpack#15690

Closed

boubou19 closed this Mar 10, 2024

		@@ -378,6 +378,15 @@ public static TFFeature generateFeatureForOldMapGen(int chunkX, int chunkZ, Worl
		}

		public static TFFeature generateFeatureFor1Point7(int chunkX, int chunkZ, World world) {

Comments

Conversation

Minepolz320 commented Jan 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dream-Master commented Jan 14, 2024

Uh oh!

Minepolz320 commented Jan 15, 2024

Uh oh!

Caedis commented Jan 16, 2024

Uh oh!

Minepolz320 commented Jan 17, 2024

Uh oh!

YannickMG commented Jan 27, 2024

Uh oh!

Minepolz320 commented Jan 28, 2024

Uh oh!

Minepolz320 commented Jan 29, 2024

Uh oh!

Minepolz320 commented Jan 31, 2024

Uh oh!

YannickMG commented Jan 31, 2024

Uh oh!

YannickMG left a comment

Choose a reason for hiding this comment

Uh oh!

YannickMG Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Minepolz320 Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

YannickMG Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

YannickMG Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

YannickMG Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

YannickMG Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

YannickMG Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

Minepolz320 Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

Minepolz320 commented Feb 1, 2024

Uh oh!

Minepolz320 commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boubou19 commented Mar 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Minepolz320 commented Jan 14, 2024 •

edited

Loading

YannickMG Jan 31, 2024 •

edited

Loading

Minepolz320 commented Feb 1, 2024 •

edited

Loading