Draft
Conversation
|
Warning: 2 uncommitted changes |
Can replace all the ore in a given stalactite
YannickMG
force-pushed
the
tf-ore-api-demo
branch
from
63be1b8 to
b258054
Compare
|
There's one thing I don't really like about this method: you can't really tweak the rarity of the stalactite you're generating, plus you're not really adding a new stalactite, you're just replacing an existing one. I would rather add an option to add new stalactites, that would've compete for generation with vanilla ones. I guess I'll have to do it in my PR) |
|
You can check my version out in #44 |
Merged
Draft
|
Did you check how it works with GT ores? Because I'm afraid that it may cause issues similar to those I got |
Author
|
In draft pending requirements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent is to allow the core mod (or any other mod) to specify which ores should be in the stalactites by providing a method to place that stalactite's blocks.
This is an alternative to the method used in #36.
Thanks to Minepolz320 for the original idea.