add setOreBlock() to API

[Minepolz320]

For GTNewHorizons/twilightforest#36

[Dream-Master]

@Minepolz320 you need to run spotless

[Minepolz320]

@Dream-Master Whoops 😅

[YannickMG]

Isn't GT_TileEntity_Ores::setOreBlock already public static and thus usable directly in Twilight Forest? Is the idea that you'd prefer to use a method that's explicitly part of the API?

[Minepolz320]

@YannickMG damn it's actually even easier

[Minepolz320]

@YannickMG yes but how can you allow the mod to run without gregtech
just prevent the method from being called or so that the jvm does not load the class

I'm a bit of a noob when it comes to mod integration.

[Minepolz320]

and yet it seems to me more obvious to have this method in the API
but maybe that's just me

[Caedis]

Any mod specific code needs to be guarded with Loader.isModLoaded(modID).

The output of that method should be cached in a public static variable during preinit so that its not constantly checking if a mod is loaded.

[YannickMG]

You could also consider not adding any dependency on gregtech.

Instead you could add an API to Twilight Forest to allow overriding the code used to set the ore for each stalactite and call that API from NewHorizonsCoreMod.

I can detail this tonight if you'd like.

[Minepolz320]

@YannickMG

Isn't GT_TileEntity_Ores::setOreBlock already public static and thus usable directly in Twilight Forest? Is the idea that you'd prefer to use a method that's explicitly part of the API?

I think this is the best option for now