Skip to content

Feat: MSVC build process + Github build workflow - #36

Merged
rikled merged 57 commits into
mainfrom
feat/buildgithub
Jun 24, 2026
Merged

Feat: MSVC build process + Github build workflow#36
rikled merged 57 commits into
mainfrom
feat/buildgithub

Conversation

@rikled

@rikled rikled commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR:

  • splits build process into common and os specific (common includes, wasm, web-apps, sdkjs, desktop-js)
  • adds support for building desktop editors for Windows based on Feat: msvc github build workflow core#95,
  • adds a .ps1 build script for building locally on a Windows machine,
  • adds a github workflow for building desktop editor packages for linux and windows
  • add and update readme files

depends on: Euro-Office/desktop-apps#24, Euro-Office/desktop-sdk#5, Euro-Office/core#107

Assisted by Claude Opus 4.8

@rikled
rikled force-pushed the feat/buildgithub branch 2 times, most recently from bde03c3 to e337fff Compare June 17, 2026 23:41
@rikled rikled changed the title Feat/buildgithub Feat: MSVC build process + Github build workflow Jun 19, 2026
This was referenced Jun 19, 2026
Merged
Merged
Merged
rikled added 24 commits June 19, 2026 13:30
@rikled
fix: desktop editors with new msvc build routine
d7d8b54 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update core
fcee519 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: secret leak in dockerfile
f7bce41 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: MSVC desktop build
2e9f65d 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: separate common from linux build, update submodules
7ee33b0 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: powershell script for building windows part of desktopeditors
bd4136c 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: use docker secret for Nextcloud user and password
691bfde 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update submodule
d4c51a6 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: github build workflow, first attempt for windows
81a44f1 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: add debug step
f257d6e 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: remove flaky cache
3fcc16f 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: enable 3dparty caching
7c5523f 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: attempt to fix image export
7010e54 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: dummy command for scratch image
248439b 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: windows build add steps for packaging
d072782 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix/feat: add linux workflow, copy common in result in windows, remov…
928e6f1 
…e advinst

Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: swap needs and build name
38c1ea4 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: add missing git short sha
e60e4ba 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: use inno version already installed
a0d3eb2 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: force overwrite desktopeditor files with common
fa20e85 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: wrong path of windows desktop builds
2ce89b8 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: completely remove advinst for now
0e21dac 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: outsource windows build logic solely into build script
d1aa0d4 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: inno package build
6c1f843 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
rikled added 19 commits June 19, 2026 13:30
@rikled
fix: update sccache
fffd072 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: ccache support for linux desktop build
c0b3bdb 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: add ccache to core-wasm build
ac1d97b 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: add WIN32 flag to windows build
0faa880 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: set win32 flag in djvufile, remove global win32 flag
9fde33d 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update submodules
523ed6f 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: attempt to fix buildx ccache
bcef4e6 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore:update submodules
7a7900a 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update submodules
4e777cb 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update submodules
bfab24d 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update submodules
2d28598 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: another attempt to fix caching
153e77b 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update submodules
9ad84f0 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update submodules
030befa 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: add missing manifest file to converter
c780052 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: allfontsgen did not create web AllFonts.js
5e336ef 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: windows build script cleanup
6f74606 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update submodules
5957229 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update submodules
a0be36f 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
rikled force-pushed the feat/buildgithub branch from 51f6be9 to a0be36f Compare June 19, 2026 20:31
@rikled
rikled marked this pull request as ready for review June 19, 2026 20:33
This was referenced Jun 19, 2026
Closed
Closed
rikled added 3 commits June 19, 2026 14:59
@rikled
chore: add readme files
9532193 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: update main repo readme
7963cda 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: smaller things in readmes
7c6c7c8 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Aiiaiiio
Aiiaiiio reviewed Jun 22, 2026
View reviewed changes
Comment thread .github/workflows/build.yml
extra_bake_files: ""
extra_targets: ""
cache_prefix: ""
#- name: nextcloud-office

@Aiiaiiio Aiiaiiio Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without explanation this comment looks tray.

@rikled
chore: update submodules to main branches for merge
841fb8f 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
@rikled
rikled merged commit 69bef73 into main Jun 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aiiaiiio Aiiaiiio Aiiaiiio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rikled @Aiiaiiio