Skip to content

Feat/msvcdesktop - #24

Merged
rikled merged 12 commits into
mainfrom
feat/msvcdesktop
Jun 24, 2026
Merged

Feat/msvcdesktop#24
rikled merged 12 commits into
mainfrom
feat/msvcdesktop

Conversation

@rikled

@rikled rikled commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR:

  • adds cmake support for windows,
  • fixes bug in inno package creation scripts,
  • improves linux build process: support for nextcloud caching, ccache, allfontsgen, allthemesgen, as this is OS specific

more details in: Euro-Office/DesktopEditors#36

Assisted by Claude Opus 4.8

@rikled rikled linked an issue Jun 13, 2026 that may be closed by this pull request
DesktopEditors: Windows build Euro-Office/DesktopEditors#31
Closed
6 tasks
@rikled rikled mentioned this pull request Jun 16, 2026
Closed
@rikled
rikled force-pushed the feat/msvcdesktop branch from cd4b811 to 42f154d Compare June 17, 2026 19:49
@rikled rikled mentioned this pull request Jun 19, 2026
Merged
rikled added 12 commits June 19, 2026 13:27
@rikled
fix: desktop editors with new msvc build routine
1062857 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: secret leak in dockerfile
4561cbc 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: MSVC desktop build
79c8661 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: linking bugs
743c477 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: add build workflow, separate common and os specific builds
6013570 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: secret leak in dockerfile
6c5b5b0 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: target is named desktop-linux
caa1c2c 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: euro-office hyphen issue in inno definitions
d7833d8 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: let windows and linux build fonts/themes by themselves to speed …
dff484c 
…up build process

Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: enable ccache for desktop build
1bc94a9 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: add WIN32 and _WINDOWS to Desktopeditors windows build
12d1811 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: remove build workflow
5f83750 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
rikled force-pushed the feat/msvcdesktop branch from 6c8e867 to 5f83750 Compare June 19, 2026 20:28
@rikled
rikled marked this pull request as ready for review June 19, 2026 20:33
@rikled rikled mentioned this pull request Jun 19, 2026
Closed
@rikled rikled closed this Jun 19, 2026
@rikled rikled reopened this Jun 19, 2026
@rikled
rikled merged commit de61732 into main Jun 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DesktopEditors: Windows build

1 participant

@rikled