Skip to content

Feat/msvcdesktop - #107

Merged
rikled merged 14 commits into
mainfrom
feat/msvcdesktop
Jun 24, 2026
Merged

Feat/msvcdesktop#107
rikled merged 14 commits into
mainfrom
feat/msvcdesktop

Conversation

@rikled

@rikled rikled commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR:

  • adds third-party build instructions for CEF (just download from spotify host), icu-desktop and QT
  • improves linux build process: add support for Nextcloud caching, ccache
  • add third-party dockerfile to build old qt dependency separately on Ubuntu 18.04
  • fixes a bug in wasm fetch script for windows
  • fixes smaller issues in cmake build process for windows

more details in: Euro-Office/DesktopEditors#36

Assisted by Claude Opus 4.8

@rikled rikled linked an issue Jun 13, 2026 that may be closed by this pull request
DesktopEditors: Windows build Euro-Office/DesktopEditors#31
Closed
6 tasks
@rikled rikled mentioned this pull request Jun 16, 2026
Closed
@rikled
rikled force-pushed the feat/msvcdesktop branch from 4fe82a7 to 59eac53 Compare June 17, 2026 19:38
@rikled rikled mentioned this pull request Jun 19, 2026
Merged
rikled added 14 commits June 19, 2026 13:24
@rikled
fix: desktop editors with new msvc build routine
791815a 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: exclude cef,qt build in cmake, wrap desktop build
ba87e51 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: exclude icu-desktop in non-desktop case
3594148 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: secret leak in dockerfile
3db3a56 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: abort_op command in 3dparty build scripts
a40114e 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: MSVC desktop build fixes
c147d99 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: converter manifest for windows and wasm fetch fix
858f876 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: get cef from official spotify website
460ed7d 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: add ccache to core-base image
f6ba730 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
feat: add ccache to core wasm build
00eea9c 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: add WIN32 to djvufile cmakelists
2ff346c 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: add missing default options to starmathconverter
5345462 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
chore: debug output for workflow
b993f31 
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
fix: remove unnecessary packages from third party, is cef is now pull…
52d1985 
…ed from spotify remote

Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Assisted-by: Claude Code:Opus 4.8
@rikled
rikled force-pushed the feat/msvcdesktop branch from 3b92913 to 52d1985 Compare June 19, 2026 20:26
@rikled
rikled marked this pull request as ready for review June 19, 2026 20:33
@rikled
rikled requested a review from a team as a code owner June 19, 2026 20:33
@rikled
rikled requested review from DmySyz and chrip and removed request for a team June 19, 2026 20:33
@rikled rikled mentioned this pull request Jun 19, 2026
Closed
@rikled
rikled merged commit ec2bd75 into main Jun 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aiiaiiio Aiiaiiio Aiiaiiio approved these changes
@chrip chrip Awaiting requested review from chrip chrip is a code owner automatically assigned from Euro-Office/core
@DmySyz DmySyz Awaiting requested review from DmySyz DmySyz is a code owner automatically assigned from Euro-Office/core

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DesktopEditors: Windows build

2 participants

@rikled @Aiiaiiio