Instrument connection limit and current count for http blackholes #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
CC @remeh |
scottopell
requested changes
Dec 30, 2024
lading/src/blackhole/common.rs
Outdated
| let shutdown_fut = shutdown.recv(); | ||
| pin!(shutdown_fut); | ||
| loop { | ||
| gauge!("connection.current", &labels).set(sem.available_permits() as f64); |
There was a problem hiding this comment.
we claim a permit upon accepting a connection, so wouldn't available_permits be the inverse of what we want? ie, we should use sem.claimed_permits to track the number of current connections
There was a problem hiding this comment.
Addressed in 75ecd70
blt
changed the base branch from
blt/unifty_httpd_in_blackholes
to
graphite-base/1190
blt
force-pushed
the
blt/instrument_connection_limit_and_current_count_for_http_blackholes
branch
from
2e1a3a2 to
a8a5566
Compare
blt
force-pushed
the
graphite-base/1190
branch
from
4d7e361 to
b2f3c8b
Compare
blt
force-pushed
the
blt/instrument_connection_limit_and_current_count_for_http_blackholes
branch
from
a8a5566 to
3fe8e76
Compare
This commit introduces telemetry keeping track of the connection limit for http blackholes and the current connection count. This is desirable information for targets that wish to trade total connections for other resources. Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/instrument_connection_limit_and_current_count_for_http_blackholes
branch
from
3fe8e76 to
75ecd70
Compare
scottopell
approved these changes
Dec 31, 2024
Merge activity
|
blt
deleted the
blt/instrument_connection_limit_and_current_count_for_http_blackholes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit introduces telemetry keeping track of the connection
limit for http blackholes and the current connection count. This is
desirable information for targets that wish to trade total connections
for other resources.