Upgrade hyper, tonic et al only in ducks #1181
Merged
+380
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
GeorgeHahn
approved these changes
Dec 24, 2024
This commit is peer to #1179 and takes an alternative approach: only upgrade hyper et al in single spots in the project. This means we have a mix of different hyper versions et al but it does compile at least. This is a wretched mess. I couldn't make tower work in ducks so it's dropped -- we'll need to add load shedding and concurrency control ourselves if we want it -- and while it's cool that hyper is now a 1.0 crate I really, really don't love that we depend on a small set of 0.1 crates to get there. I don't know if I would rather just opt into axum or not, although hyper at least will be a going concern in the ecosystem with high probability. Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/upgrade_hyper_tonic_et_al_only_in_ducks
branch
from
bfbdbb2 to
6d299ad
Compare
blt
added a commit
that referenced
this pull request
Dec 27, 2024
This commit re-unifies our crates at the workspace level, reversing a process begun in #1181 in order to upgrade hyper et al in a feasible way. Signed-off-by: Brian L. Troutwine <[email protected]>
This was referenced Dec 27, 2024
Merge activity
|
blt
added a commit
that referenced
this pull request
Dec 30, 2024
This commit re-unifies our crates at the workspace level, reversing a process begun in #1181 in order to upgrade hyper et al in a feasible way. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
added a commit
that referenced
this pull request
Dec 30, 2024
This commit re-unifies our crates at the workspace level, reversing a process begun in #1181 in order to upgrade hyper et al in a feasible way. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
added a commit
that referenced
this pull request
Dec 30, 2024
This commit re-unifies our crates at the workspace level, reversing a process begun in #1181 in order to upgrade hyper et al in a feasible way. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
added a commit
that referenced
this pull request
Dec 30, 2024
This commit re-unifies our crates at the workspace level, reversing a process begun in #1181 in order to upgrade hyper et al in a feasible way. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
added a commit
that referenced
this pull request
Dec 30, 2024
This commit re-unifies our crates at the workspace level, reversing a process begun in #1181 in order to upgrade hyper et al in a feasible way. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
added a commit
that referenced
this pull request
Dec 30, 2024
### What does this PR do? This commit re-unifies our crates at the workspace level, reversing a process begun in #1181 in order to upgrade hyper et al in a feasible way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit is peer to #1179 and takes an alternative approach: only
upgrade hyper et al in single spots in the project. This means we have
a mix of different hyper versions et al but it does compile at least.
This is a wretched mess. I couldn't make tower work in ducks so it's
dropped -- we'll need to add load shedding and concurrency control ourselves
if we want it -- and while it's cool that hyper is now a 1.0 crate I
really, really don't love that we depend on a small set of 0.1 crates
to get there. I don't know if I would rather just opt into axum or not,
although hyper at least will be a going concern in the ecosystem
with high probability.