Unifty httpd in blackholes #1187
Merged
+303
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blt
force-pushed
the
blt/re-unify_crates_at_workspace
branch
from
977e2c1 to
8c123ec
Compare
blt
force-pushed
the
blt/unifty_httpd_in_blackholes
branch
from
eaf3562 to
ed698ac
Compare
scottopell
approved these changes
Dec 30, 2024
| where | ||
| // "service factory" | ||
| SF: Send + Sync + 'static + Clone + Fn() -> S, | ||
| // The bounds on `S` per |
There was a problem hiding this comment.
helpful comments, thanks
There was a problem hiding this comment.
I found it very hard to keep straight myself.
blt
force-pushed
the
blt/re-unify_crates_at_workspace
branch
from
8c123ec to
086520b
Compare
blt
force-pushed
the
blt/unifty_httpd_in_blackholes
branch
from
ed698ac to
72aad51
Compare
blt
force-pushed
the
blt/re-unify_crates_at_workspace
branch
2 times, most recently
from
bbac7b4 to
6344aba
Compare
blt
force-pushed
the
blt/unifty_httpd_in_blackholes
branch
from
a1e268c to
6c7cfc1
Compare
blt
force-pushed
the
blt/re-unify_crates_at_workspace
branch
from
6344aba to
425c381
Compare
blt
force-pushed
the
blt/unifty_httpd_in_blackholes
branch
from
6c7cfc1 to
aa1d0a8
Compare
GeorgeHahn
approved these changes
Dec 30, 2024
blt
changed the base branch from
blt/re-unify_crates_at_workspace
to
graphite-base/1187
blt
force-pushed
the
graphite-base/1187
branch
from
425c381 to
c7aa607
Compare
blt
force-pushed
the
blt/unifty_httpd_in_blackholes
branch
from
aa1d0a8 to
6810a8b
Compare
blt
force-pushed
the
blt/unifty_httpd_in_blackholes
branch
from
6810a8b to
d899db2
Compare
This commit unifies the httpd bits of the blackholes, removing a duplicated loop in three places. The type logic here started out general and got gradually more concrete and there's scope to reduce duplication even further but I don't know that it's a pressing issue. Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/unifty_httpd_in_blackholes
branch
from
d899db2 to
4d7e361
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit unifies the httpd bits of the blackholes, removing a duplicated loop in three places. The type logic here started out general and got gradually more concrete and there's scope to reduce duplication even further but I don't know that it's a pressing issue.