Skip to content

refactor: CallHandler logic in interpreter#312

Open
ys8888john wants to merge 1 commit intoDTVMStack:mainfrom
ys8888john:fix-interp-call
Open

refactor: CallHandler logic in interpreter#312
ys8888john wants to merge 1 commit intoDTVMStack:mainfrom
ys8888john:fix-interp-call

Conversation

@ys8888john
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains CI/CD configuration changes
  • Contains documentation changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

None

Copy link
Contributor

@starwarfan starwarfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if (Rev >= EVMC_BERLIN && !CoinbaseIsWarm &&
if (Rev >= EVMC_BERLIN &&
Frame->Host->access_account(Dest) == EVMC_ACCESS_COLD) {
// Charge additional cold access cost (2600 - 100 = 2500)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove or modify the comment simultaneously

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on dima? It is just been completed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not serious problem, it's ok keep here.

@ys8888john ys8888john force-pushed the fix-interp-call branch 2 times, most recently from 4e0afee to 637b228 Compare February 4, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants