Skip to content

fix: remove call stipend refund adjustment for blob tx gas accounting#332

Open
abmcar wants to merge 1 commit intoDTVMStack:mainfrom
abmcar:fix/host-blob
Open

fix: remove call stipend refund adjustment for blob tx gas accounting#332
abmcar wants to merge 1 commit intoDTVMStack:mainfrom
abmcar:fix/host-blob

Conversation

@abmcar
Copy link
Contributor

@abmcar abmcar commented Feb 4, 2026

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains CI/CD configuration changes
  • Contains documentation changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

None

Copilot AI review requested due to automatic review settings February 4, 2026 10:12
@abmcar
Copy link
Contributor Author

abmcar commented Feb 4, 2026

Fix the host to align with the changes in PR #312 so that, together with PR #312’s modifications, it can pass CI.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes incorrect gas accounting for blob transactions by removing the erroneous CallStipendRefund tracking mechanism. The call stipend (2300 gas) is a special gas allowance added to CALL operations that transfer value, which is already properly handled at the opcode/instruction level. The removed code was incorrectly tracking and subtracting this stipend again during transaction-level gas accounting for blob transactions, resulting in double-counting.

Changes:

  • Removed CallStipendRefund member variable and its initialization logic
  • Removed call stipend refund adjustments from gas accounting in precompile execution, contract creation, and regular execution paths
  • Removed call stipend tracking logic from the call_internal method
  • Applied code formatting improvements including header reordering and multi-line statement alignment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant