Skip to content

Conversation

@ECNUyhy
Copy link
Contributor

@ECNUyhy ECNUyhy commented Jan 29, 2026

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains CI/CD configuration changes
  • Contains documentation changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

None

Copy link
Contributor

@starwarfan starwarfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#312 is for interpreter to pass the evmone unittest.
You change fails the evmone unittest for multipass.

[  FAILED  ] multi_vm/evm.call_failing_with_value/external_vm, where GetParam() = 0x602000006f10
[  FAILED  ] multi_vm/evm.call_new_account_creation_cost/external_vm, where GetParam() = 0x602000006f10

Looks like the state test you tend to fix conflicts with evmone's unittest.

@zoowii
Copy link
Contributor

zoowii commented Feb 5, 2026

conflict

constexpr bool PRINT_FAILURE_DETAILS = true;
// TODO: RunMode selection logic will be refactored in the future.
constexpr auto STATE_TEST_RUN_MODE = common::RunMode::MultipassMode;
constexpr auto STATE_TEST_RUN_MODE = common::RunMode::InterpMode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change to InterpMode by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest #334 defaults to InterpMode.

@cmgCr
Copy link
Contributor

cmgCr commented Feb 6, 2026

It seems these *.expected files are redundant.

@ECNUyhy
Copy link
Contributor Author

ECNUyhy commented Feb 6, 2026

It seems these *.expected files are redundant.

evm_interp_tests then scans all .evm.hex files and fails if a matching .expected is missing.So these .expected files are not redundant—they are the missing golden outputs for shift tests that are now actually executed. Removing them would make the interpreter tests fail unless we also stop generating those .evm.hex files or relax the test requirements.

@zoowii zoowii merged commit 2c81ae4 into DTVMStack:main Feb 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants