Skip to content

Conversation

@renefritze
Copy link
Contributor

This updates the used Antlr version to make the project usable with Python 3.13.

Some Github Action workflows needed updating to make CI pass in my fork.

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2025

CLA assistant check
All committers have signed the CLA.

@ryanmrichard
Copy link
Collaborator

ryanmrichard commented Jul 3, 2025

@zachcran can you take a look at the canceled test?

@renefritze
Copy link
Contributor Author

@zachcran can you take a look at the canceled test?

9731b8d should do it @ryanmrichard

@zachcran
Copy link

zachcran commented Jul 3, 2025

@renefritze @ryanmrichard I agree that switching to ubuntu-latest should fix the cancelled test issue.

@ryanmrichard
Copy link
Collaborator

Unfortunately it looks like it didn’t. Once we fix this, we may want to setup nightly runs to catch stuff like this quicker.

@zachcran
Copy link

zachcran commented Jul 6, 2025

Once we fix this, we may want to setup nightly runs to catch stuff like this quicker.

I made #166 to propose and track implementing a regularly scheduled run of the CI.

@zachcran
Copy link

zachcran commented Jul 6, 2025

Unfortunately it looks like it didn’t.

@ryanmrichard I'm not sure what you mean; is the test still being cancelled? I think I am seeing a non-cancelled run of test_release here, so the "test being cancelled" issue should be fixed, right? The test is failing now, but that is another issue to resolve.

renefritze and others added 3 commits July 7, 2025 09:02
Co-authored-by: Zachery Crandall <[email protected]>
Co-authored-by: Zachery Crandall <[email protected]>
Co-authored-by: Zachery Crandall <[email protected]>
@zachcran
Copy link

zachcran commented Jul 7, 2025

...and we're back to the drawing board. I thought for sure setting packaging>=24.2 would have been the fix since that is the only way I could replicate the issue.

After checking the logs and rerunning the action to see it in real time, the install step is going way too fast to actually be installing from scratch. Annoyingly, the install step does not appear to be providing any output at all. My local system behaves that way when pip has nothing to do. My first thought is that we should set the action up to use a virtual environment, as I point out in #170 should be done in all CI. @ryanmrichard @renefritze Any thoughts or ideas?

@renefritze
Copy link
Contributor Author

...and we're back to the drawing board. I thought for sure setting packaging>=24.2 would have been the fix since that is the only way I could replicate the issue.

After checking the logs and rerunning the action to see it in real time, the install step is going way too fast to actually be installing from scratch. Annoyingly, the install step does not appear to be providing any output at all. My local system behaves that way when pip has nothing to do. My first thought is that we should set the action up to use a virtual environment, as I point out in #170 should be done in all CI. @ryanmrichard @renefritze Any thoughts or ideas?

In any of my projects I would just also manage the CI env and execution with uv. And commit its lockfile. In the same kind of vein, I could export a requirements file from the working lockfile and add that instead.

@renefritze
Copy link
Contributor Author

...and we're back to the drawing board. I thought for sure setting packaging>=24.2 would have been the fix since that is the only way I could replicate the issue.
After checking the logs and rerunning the action to see it in real time, the install step is going way too fast to actually be installing from scratch. Annoyingly, the install step does not appear to be providing any output at all. My local system behaves that way when pip has nothing to do. My first thought is that we should set the action up to use a virtual environment, as I point out in #170 should be done in all CI. @ryanmrichard @renefritze Any thoughts or ideas?

In any of my projects I would just also manage the CI env and execution with uv. And commit its lockfile. In the same kind of vein, I could export a requirements file from the working lockfile and add that instead.

Something like this: https://github.com/renefritze/CMinx/pull/4/files

@renefritze
Copy link
Contributor Author

...and we're back to the drawing board. I thought for sure setting packaging>=24.2 would have been the fix since that is the only way I could replicate the issue.
After checking the logs and rerunning the action to see it in real time, the install step is going way too fast to actually be installing from scratch. Annoyingly, the install step does not appear to be providing any output at all. My local system behaves that way when pip has nothing to do. My first thought is that we should set the action up to use a virtual environment, as I point out in #170 should be done in all CI. @ryanmrichard @renefritze Any thoughts or ideas?

In any of my projects I would just also manage the CI env and execution with uv. And commit its lockfile. In the same kind of vein, I could export a requirements file from the working lockfile and add that instead.

Something like this: https://github.com/renefritze/CMinx/pull/4/files

In that PR everything but the licensing check works now @zachcran

I've also created a separate PR that updated and applies licenser. I've done that with the current version 0.7 via docker. The workflow uses the older 0.4

@zachcran
Copy link

@renefritze Sorry for the delayed response! I think switching everything over to uv will take more consideration and research than we have the bandwidth for right now on our end. I think the implementations on your branch look great, but since it sounds like none of the active maintainers on the project know uv (mainly @ryanmrichard), it is probably safer and faster to stick with the basic tools to get this PR through. Then, we can be a bit more methodical about considering and migrating to other tools when it isn't entangled with broken workflows holding up a PR.

Since you've already made some changes to the CI workflows here to get things working, I'll try committing a few things to fix the workflow instead of replicating a bunch of work in a separate PR. Since I need to be making commits to your fork for them to appear on this PR (afaik), please feel free to roll back anything I do.

@zachcran
Copy link

The combination of fb01845 and cf7b33f allowed the test_release workflow to pass. This marks partial completion of #170.

@zachcran zachcran linked an issue Jul 15, 2025 that may be closed by this pull request
Copy link

@zachcran zachcran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the purposes of this PR, LGTM. There will need to be more workflow maintenance to follow, though. Let's see if the current tests all pass.

@zachcran
Copy link

@ryanmrichard This seems to be held up by required checks that no longer exist due to changes in this PR. The build checks for versions 3.8.13, 3.9.13, and 3.10.5 have been replaced with the passing checks for the latest patches of versions 3.9, 3.10, 3.11, 3.12, and 3.13.

Will you update the required checks, please?

@ryanmrichard ryanmrichard merged commit 901f0ab into CMakePP:master Jul 15, 2025
15 checks passed
@github-actions
Copy link

🚀 [bumpr] Bumped!
New version:v1.1.12
Changes:v1.1.11...v1.1.12

@renefritze
Copy link
Contributor Author

Many thanks for getting this through @ryanmrichard @zachcran

@ryanmrichard
Copy link
Collaborator

@renefritze and thank you for your patience. Like probably everyone, we're trying to do way too many things at once...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update runners away from discontinued ubuntu-20.04

4 participants