Skip to content

Use semantically correct bool comparison for some metrics field tests #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msimberg merged 2 commits into from
Nov 18, 2025
Merged

Use semantically correct bool comparison for some metrics field tests #948

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0aae1b6
Use semantically correct bool comparison for some metrics field tests
msimberg Nov 17, 2025
2b5ab00
Fix dtype for mask_hdiff in metrics_attributes.py
msimberg Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions model/common/tests/common/metrics/unit_tests/test_metrics_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ def test_factory_mask_bdy_prog_halo_c(
)
field_1 = factory.get(attrs.MASK_PROG_HALO_C)
field_2 = factory.get(attrs.BDY_HALO_C)
assert test_helpers.dallclose(field_ref_1.asnumpy(), field_1.asnumpy())
assert (field_ref_1.asnumpy() == field_1.asnumpy()).all()
assert test_helpers.dallclose(field_ref_2.asnumpy(), field_2.asnumpy())


Expand Down Expand Up @@ -641,7 +641,7 @@ def test_factory_compute_diffusion_mask_and_coef(
field_1 = factory.get(attrs.MASK_HDIFF)
field_2 = factory.get(attrs.ZD_DIFFCOEF_DSL)

assert test_helpers.dallclose(field_ref_1.asnumpy(), field_1.asnumpy())
assert (field_ref_1.asnumpy() == field_1.asnumpy()).all()
assert test_helpers.dallclose(field_ref_2.asnumpy(), field_2.asnumpy(), atol=1.0e-10)


Expand Down
Loading