Use semantically correct bool comparison for some metrics field tests#948
Use semantically correct bool comparison for some metrics field tests#948
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates comparison assertions in two test functions to use exact equality checks instead of the dallclose helper function, with the intent of making these comparisons semantically correct for boolean fields.
- Changed assertions from
dallcloseto(field == field).all()for two mask fields - Applied to
MASK_PROG_HALO_Cintest_factory_mask_bdy_prog_halo_c - Applied to
MASK_HDIFFintest_factory_compute_diffusion_mask_and_coef
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
cscs-ci run default |
0acd8b3 to
2b5ab00
Compare
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
Just extracts a minor inconsistency from #853. Also fixes dtype for mask_hdiff.