Skip to content

reactions: Increase prominence of own reactions, following web #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024
Merged

reactions: Increase prominence of own reactions, following web #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/widgets/emoji_reaction.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ const _backgroundColorSelected = Colors.white;
// Until then use a solid color; a much-lightened version of the shadow color.
// Also adapt by making [_borderColorUnselected] more transparent, so we'll
// want to check that against web when implementing the shadow.
final _backgroundColorUnselected = const HSLColor.fromAHSL(0.15, 210, 0.50, 0.875).toColor();
final _backgroundColorUnselected = const HSLColor.fromAHSL(0.08, 210, 0.50, 0.875).toColor();

final _borderColorSelected = Colors.black.withOpacity(0.40);
final _borderColorSelected = Colors.black.withOpacity(0.45);
// TODO see TODO on [_backgroundColorUnselected] about shadow effect
final _borderColorUnselected = Colors.black.withOpacity(0.06);
final _borderColorUnselected = Colors.black.withOpacity(0.05);

class ReactionChip extends StatelessWidget {
final bool showName;
Expand Down Expand Up @@ -91,7 +91,10 @@ class ReactionChip extends StatelessWidget {
final splashColor = selfVoted ? _backgroundColorUnselected : _backgroundColorSelected;
final highlightColor = splashColor.withOpacity(0.5);

final borderSide = BorderSide(color: borderColor, width: 1);
final borderSide = BorderSide(
color: borderColor,
width: selfVoted ? 1.5 : 1.0,
);
final shape = StadiumBorder(side: borderSide);

final Widget emoji;
Expand Down
Loading