Skip to content

reactions: Increase prominence of own reactions, following web #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024

Conversation

chrisbobbe
Copy link
Collaborator

This follows zulip/zulip@793020992, which landed after we implemented reaction chips here. (That commit makes some padding adjustments, which we don't need because changing a chip's border width doesn't affect the chip's size.)

Before After
Screenshot 2024-05-15 at 2 46 13 PM Screenshot 2024-05-15 at 2 46 37 PM

This follows zulip/zulip@793020992, which landed after we
implemented reaction chips here. (That commit makes some padding
adjustments, which we don't need because changing a chip's border
width doesn't affect the chip's size.)
@chrisbobbe chrisbobbe added a-design Visual and UX design integration review Added by maintainers when PR may be ready for integration labels May 15, 2024
@chrisbobbe chrisbobbe requested a review from gnprice May 15, 2024 21:50
@chrisbobbe
Copy link
Collaborator Author

Like PR #657, this is meant to fix a small deviation from web in our light-theme implementation, toward #95.

@gnprice
Copy link
Member

gnprice commented May 16, 2024

LGTM, thanks! Merging.

@gnprice gnprice merged commit 181f65a into zulip:main May 16, 2024
1 check passed
@chrisbobbe chrisbobbe deleted the pr-reaction-chip-prominence branch May 16, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-design Visual and UX design integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants