Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msglist: Follow user settings for message timestamps #1398

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

msglist: Follow user settings for message timestamps #1398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/widgets/message_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,7 +1334,10 @@ class MessageWithPossibleSender extends StatelessWidget {

Widget? senderRow;
if (item.showSender) {
final time = _kMessageTimestampFormat
final userSettings = store.userSettings;
final is24HourFormat = userSettings?.twentyFourHourTime;
final timeFormat = DateFormat(getTimeFormat(is24HourFormat ?? false), ZulipLocalizations.of(context).localeName);
final time = timeFormat
.format(DateTime.fromMillisecondsSinceEpoch(1000 * message.timestamp));
senderRow = Row(
mainAxisAlignment: MainAxisAlignment.spaceBetween,
Expand Down Expand Up @@ -1438,4 +1441,6 @@ class MessageWithPossibleSender extends StatelessWidget {
}

// TODO(i18n): web seems to ignore locale in formatting time, but we could do better
final _kMessageTimestampFormat = DateFormat('h:mm aa', 'en_US');
String getTimeFormat(bool is24Hour) {
return is24Hour ? 'HH:mm' : 'h:mm aa';
}