msglist: Follow user settings for message timestamps #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, timestamps were always formatted as 12-hour (h:mm aa), ignoring the user's preference `twentyFourHourTime` in settings. Now, the code retrieves the user's setting and selects the appropriate format: • 24-hour format: "HH:mm" • 12-hour format: "h:mm aa"
|
Thanks for picking this up. This is a post-launch issue, so we won't be able to spend time reviewing this PR in the next month or two before the app launches. Compare #1152 (comment) . If you'd like to contribute to Zulip, the best thing to work on next would be revising your existing open PR to respond to the review feedback there. In general that's the top priority among Zulip work. |
|
Thanks for the update! 🙂 I understand the current priorities and I'll revisit this issue later when post launch begins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1015
Summary
The message timestamps now uses user's
twentyFourHourTimesettings.Previously, timestamps were always formatted in 12-hour format (
h:mm aa), irrespective of the user's preference.With this fix, timestamps now correctly switch between:
HH:mmh:mm aaChanges Made
twentyFourHourTimesetting fromuserSettings.Screenshots