Skip to content

Align UssSetAcl parameter naming with RESTfiles API #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankgiordano merged 1 commit into from
Apr 30, 2026
Merged

Align UssSetAcl parameter naming with RESTfiles API #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/zowe/client/sdk/zosfiles/uss/methods/UssSetAcl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ public Response delete(final String targetPath, final String value) throws Zosmf
* @throws ZosmfRequestException request error state
* @author James Kostrewski
*/
public Response deleteByType(final String targetPath, final DeleteAclType deleteType) throws ZosmfRequestException {
public Response deleteByType(final String targetPath, final DeleteAclType deleteType)
throws ZosmfRequestException {
return setAclCommon(targetPath, new UssSetAclInputData.Builder().setDeleteType(deleteType).build());
}

Expand All @@ -132,7 +133,7 @@ public Response deleteByType(final String targetPath, final DeleteAclType delete
*/
public Response setAclCommon(final String targetPath, final UssSetAclInputData setAclInputData)
throws ZosmfRequestException {
ValidateUtils.checkIllegalParameter(targetPath, "fromPath");
Copy link
Copy Markdown
Collaborator

@frankgiordano frankgiordano Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to keep targetPath usage as method variable names, just change this statement only:
ValidateUtils.checkIllegalParameter(targetPath, "filePathName");
for now.

ValidateUtils.checkIllegalParameter(targetPath, "filePathName");
ValidateUtils.checkNullParameter(setAclInputData, "setAclInputData");
ValidateUtils.checkIllegalParameter(setAclInputData.getSet().isEmpty() &&
setAclInputData.getModify().isEmpty() && setAclInputData.getDelete().isEmpty() &&
Expand Down
Loading