Align UssSetAcl parameter naming with RESTfiles API#480
Align UssSetAcl parameter naming with RESTfiles API#480frankgiordano merged 1 commit intozowe:mainfrom
Conversation
|
This is the smaller changes PR as requested, but yep about the factory refactor, would you like me to start working on that, or would you guide me later during the mentorship, what are your thoughts |
| public Response setAclCommon(final String targetPath, final UssSetAclInputData setAclInputData) | ||
| public Response setAclCommon(final String filePathName, final UssSetAclInputData setAclInputData) | ||
| throws ZosmfRequestException { | ||
| ValidateUtils.checkIllegalParameter(targetPath, "fromPath"); |
There was a problem hiding this comment.
i want to keep targetPath usage as method variable names, just change this statement only:
ValidateUtils.checkIllegalParameter(targetPath, "filePathName");
for now.
|
The factory refactor is outside the scope of the mentorship program, which is focused only on the workflow APIs. That said, if you have time, you can still submit the factory refactor changes for review separately. Maybe email me your proposed approach first, including a small code snippet showing how you would rework it. I will likely be working on this as well over the next few days. If you come up with a solid solution before I do, we can review it and potentially move forward with your approach. |
1fd7a19 to
b6c5820
Compare
Signed-off-by: Ashish Kumar Dash <ashishdash2410@gmail.com>
b6c5820 to
14f3f48
Compare
makes sense, like I've said earlier also, I hope to become a core contributor so I want to touch anything that come my way & be useful. I will run by you if I can think of something. For now I will concentrate on my exams :) |
Summary