Skip to content

Align UssSetAcl parameter naming with RESTfiles API#480

Merged
frankgiordano merged 1 commit intozowe:mainfrom
Ashish-Kumar-Dash:uss-setacl-filepathname
Apr 30, 2026
Merged

Align UssSetAcl parameter naming with RESTfiles API#480
frankgiordano merged 1 commit intozowe:mainfrom
Ashish-Kumar-Dash:uss-setacl-filepathname

Conversation

@Ashish-Kumar-Dash
Copy link
Copy Markdown
Contributor

Summary

  • Rename UssSetAcl path parameter to filePathName for API consistency.
  • Update Javadocs, validation label, and URL construction.

@Ashish-Kumar-Dash
Copy link
Copy Markdown
Contributor Author

This is the smaller changes PR as requested, but yep about the factory refactor, would you like me to start working on that, or would you guide me later during the mentorship, what are your thoughts

public Response setAclCommon(final String targetPath, final UssSetAclInputData setAclInputData)
public Response setAclCommon(final String filePathName, final UssSetAclInputData setAclInputData)
throws ZosmfRequestException {
ValidateUtils.checkIllegalParameter(targetPath, "fromPath");
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to keep targetPath usage as method variable names, just change this statement only:
ValidateUtils.checkIllegalParameter(targetPath, "filePathName");
for now.

@frankgiordano
Copy link
Copy Markdown
Collaborator

The factory refactor is outside the scope of the mentorship program, which is focused only on the workflow APIs.

That said, if you have time, you can still submit the factory refactor changes for review separately. Maybe email me your proposed approach first, including a small code snippet showing how you would rework it.

I will likely be working on this as well over the next few days. If you come up with a solid solution before I do, we can review it and potentially move forward with your approach.

@Ashish-Kumar-Dash Ashish-Kumar-Dash force-pushed the uss-setacl-filepathname branch from 1fd7a19 to b6c5820 Compare April 30, 2026 18:17
Signed-off-by: Ashish Kumar Dash <ashishdash2410@gmail.com>
@Ashish-Kumar-Dash Ashish-Kumar-Dash force-pushed the uss-setacl-filepathname branch from b6c5820 to 14f3f48 Compare April 30, 2026 18:20
@Ashish-Kumar-Dash
Copy link
Copy Markdown
Contributor Author

The factory refactor is outside the scope of the mentorship program, which is focused only on the workflow APIs.

That said, if you have time, you can still submit the factory refactor changes for review separately. Maybe email me your proposed approach first, including a small code snippet showing how you would rework it.

I will likely be working on this as well over the next few days. If you come up with a solid solution before I do, we can review it and potentially move forward with your approach.

makes sense, like I've said earlier also, I hope to become a core contributor so I want to touch anything that come my way & be useful. I will run by you if I can think of something. For now I will concentrate on my exams :)

@frankgiordano frankgiordano merged commit ac0f1ef into zowe:main Apr 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants