-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the toml implementation from standard lib. #209
Conversation
Unfortunately, the standard lib only supplies read-only functionality. `tomli-w` is a small TOML writing library. I shoud be enough for our purpose, but it cannot write comments Using `tomlkit` would allow fine more finely grained editing, but comes with a whole new data structure and needs a bigger refactoring.
This solves #118. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small text change. I'll leave the actual review to Michael.
@@ -91,7 +91,8 @@ Usage | |||
Preparation | |||
+++++++++++ | |||
|
|||
The script needs a ``venv`` with some packages installed:: | |||
The script needs a ``venv`` with at Python > 3.11 with some packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script needs a ``venv`` with at Python > 3.11 with some packages | |
The script needs a ``venv`` with at least Python 3.11 and some dependencies |
My gut feeling is that if we spend time on switching TOML libraries then it makes more sense to invest a little more and switch to |
See #215 for an alternative implementation that uses |
Superseded by #215. Thank you for the initial implementation. |
Unfortunately, the standard lib only supplies read-only functionality.
tomli-w
is a smallTOML
writing library. I should be enough for our purpose, but it cannot write commentsUsing
tomlkit
would allow fine more finely grained editing, but comes with a whole new data structure and needs a bigger refactoring.The changes in this PR will change the formatting of the .meta.toml slightly, see the result for the Zope package
Diff of the .meta.toml in Zope