Separate testenv setups for lint and package-checks #216
Conversation
…(2023-10-07) Python 3.7 is already end of Life (since 2023-06-27). see https://devguide.python.org/versions/ for reference
|
We all are aware that Python 3.7 is EOL. But dropping support for it requires a bit more discussion than just declaring it within this tool. |
…kages, usage of flake8 is optional.
|
@dataflake I can refactor that change out (Python 3.7 EOL) in a different pull request, as that needs to be done by a certain point. But I do want to have separate testenvs for linting and packaging checks |
|
Thank you for factoring out the Python 3.7 parts. I'm ±0 on this PR - you're saying the combined lint environment is not useful, but don't provide an explanation why. |
|
Thanks @dataflake for me linting and checks if the package is releaseable is something different. My own opinion is, that you should actually run all test always before commiting anything. in the long run I would like if we could get pre-commit in the default set of tools. But pre-commit should only test necessary test steps locally. a check of manfifest, or python-versions-check is not necessary locally. |
|
I always run all tests myself before committing. I don't mind a test that always fails as long as I know why that is and there will be a fix coming at some point. I don't distinguish between "necessary" and other steps. So in the end I am still ±0 on this change. It seems to be a matter of taste. |
|
Actually I just saw a redeeming factor. That new test builds the sdist and tests it. We didn't have that before, I like it. |
…thub.com:zopefoundation/meta into meta_separate_setops_for_lint_and_package_checks
dataflake
deleted the
meta_separate_setops_for_lint_and_package_checks
branch
| @@ -98,7 +98,7 @@ Preparation | |||
|
|
|||
| The script needs a ``venv`` with some packages installed:: | |||
|
|
|||
| $ python3.11 -m venv . | |||
| $ python3 -m venv . | |||
There was a problem hiding this comment.
This change is not correct: The code in this repository requires to use Python 3.11+.
| @@ -271,6 +271,9 @@ updated. Example: | |||
| " src/foo/bar.py: E221 E222", | |||
| "extend-ignore = D203, W503", | |||
| ] | |||
| additional-plugins = [ | |||
| "maccabe" | |||
| @@ -522,6 +525,10 @@ additional-config | |||
| list of strings so the leading white spaces and comments are preserved when | |||
| writing the value to ``setup.cfg``. | |||
|
|
|||
| additional-plugins | |||
| Some packages want to have additional flake8 plugins installed. | |||
| *Caution:* This option has to be a list of strings. | |||
There was a problem hiding this comment.
There is no need for extra *Caution:* as the option name is plural.
| @@ -1,6 +1,7 @@ | |||
| [tox] | |||
| minversion = 3.18 | |||
| envlist = | |||
| release-check | |||
There was a problem hiding this comment.
I think this env should also run on GHA but it should be allowed to fail without failing the build.
So the release manager is not surprised when running this env before the release that fixes are needed. (I personally rely on GHA being green before the release, I do not always run the tests localy before cutting a release.)
|
Jens Vagelpohl wrote at 2023-10-17 03:28 -0700:
@dataflake commented on this pull request.
> @@ -98,7 +98,7 @@ Preparation
The script needs a ``venv`` with some packages installed::
- $ python3.11 -m venv .
+ $ python3 -m venv .
You changed that from Python 3.8 to 3.11 in 1ef8b9b but I can't see anything in that change set that requires 3.11+. I know that #209 would require 3.11, but that's not merged.
Apparently, `tox` tries to access `tomllib`, available from
Python 3.11 on.
I got corresponding test failures with a Python 3.11 alpha release
and had to upgrade to a release version.
|
combined tox testenvs for linting and package checks are not usefull, so seperate those two tests that has been together on a testenv:lint into testenv:package-checks and testenv:lint.