Skip to content

Rails 6.0 limit graphql #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tooyosi wants to merge 12 commits into from
Closed

Rails 6.0 limit graphql #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d4cdb16
update rspec to fix ActionView::Template::Error
Tooyosi Apr 21, 2025
91b4904
add platform x86_64-linux to next.lock
Tooyosi Apr 21, 2025
74e46aa
add platform x86_64-linux to next.lock
Tooyosi Apr 21, 2025
259ac09
add omniauth-oauth2 to gemfile
Tooyosi Apr 21, 2025
b3292b9
update rubygems version in dockerdile.next
Tooyosi Apr 21, 2025
5320ab6
install bundler version in dockerfile
Tooyosi Apr 21, 2025
d3b6391
add update-rubygems to test run for upgrade
Tooyosi Apr 21, 2025
ffc9263
remove update-rubygems from run_tests and add ruby as platform
Tooyosi Apr 21, 2025
2590044
limit fix to just rspec update
Tooyosi Apr 22, 2025
65d6322
update gemfile.lock
Tooyosi Apr 22, 2025
d138687
add omniauth-oauth2 to gemfile to fix error
Tooyosi Apr 22, 2025
94b6b93
limit graphql to non breaking version
Tooyosi Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile.rails-next
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ ENV RAILS_ENV=$RAILS_ENV

RUN bundle config --global jobs `cat /proc/cpuinfo | grep processor | wc -l | xargs -I % expr % - 1` && \
if echo "development test" | grep -w "$RAILS_ENV"; then \
gem update --system 3.3.22 \
gem install bundler --version 2.3.26 \
bundle install; \
else bundle install --without development test; fi

Expand Down
6 changes: 4 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ gem 'httparty'
# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
if next?
gem "rails", '6.0.6.1'
gem 'omniauth-oauth2'
Copy link

@hound hound bot Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem omniauth-oauth2 should appear before rails.

gem 'graphql', "1.12"
Copy link

@hound hound bot Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem graphql should appear before omniauth-oauth2.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

else
gem 'rails', '~> 5.2'
gem 'graphql'
Copy link

@hound hound bot Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler/DuplicatedGem: Gem graphql requirements already given on line 17 of the Gemfile.
Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem graphql should appear before rails.

end
# Use postgresql as the database for Active Record
gem 'pg', '~> 1.3'
Expand Down Expand Up @@ -55,7 +58,6 @@ gem 'rest-client', '> 2.0'
gem 'jsonpath'
gem 'simple_form'
gem 'pundit', "~> 2.2.0"
gem 'graphql'
gem 'graphiql-rails'
gem 'stoplight'
gem 'ranked-model'
Expand All @@ -78,7 +80,7 @@ group :development, :test do
# Call 'byebug' anywhere in the code to stop execution and get a debugger console
gem 'byebug', platform: [:mri, :mingw, :x64_mingw]
gem 'pry-byebug'
gem 'rspec-rails', '~> 3.8'
gem 'rspec-rails'
gem 'pry-rails'
gem 'webmock'
gem 'spring-commands-rspec'
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ DEPENDENCIES
ranked-model
responders
rest-client (> 2.0)
rspec-rails (~> 3.8)
rspec-rails
rubocop
sass-rails (~> 5.0)
sentry-raven
Expand Down
Loading