Skip to content

Comments

Rails 6.0 limit graphql#1625

Closed
Tooyosi wants to merge 12 commits intomasterfrom
rails-6.0-limit-graphql
Closed

Rails 6.0 limit graphql#1625
Tooyosi wants to merge 12 commits intomasterfrom
rails-6.0-limit-graphql

Conversation

@Tooyosi
Copy link
Collaborator

@Tooyosi Tooyosi commented Apr 22, 2025

  • Pin graphql to 1.12 (pending proper graphql upgrades: See). Fixes the failed run here
  • Require ostruct in application.rb for graphql 1.12

@Tooyosi Tooyosi requested a review from yuenmichelle1 April 22, 2025 15:47
gem 'graphql', "1.12"
else
gem 'rails', '~> 5.2'
gem 'graphql'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler/DuplicatedGem: Gem graphql requirements already given on line 17 of the Gemfile.
Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem graphql should appear before rails.

if next?
gem "rails", '6.0.6.1'
gem 'omniauth-oauth2'
gem 'graphql', "1.12"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem graphql should appear before omniauth-oauth2.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
if next?
gem "rails", '6.0.6.1'
gem 'omniauth-oauth2'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem omniauth-oauth2 should appear before rails.

@Tooyosi Tooyosi marked this pull request as draft April 22, 2025 15:49
@Tooyosi Tooyosi closed this Apr 23, 2025
@Tooyosi Tooyosi deleted the rails-6.0-limit-graphql branch April 23, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant