Add the source of sui example package #70
Conversation
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
At this point I think we should rather change the structure to be this way
├── contracts/
│ ├── gateway/
│ │ ├── Move.toml
│ │ └── sources/
│ ├── example/
│ │ ├── Move.toml
│ │ └── sources/
|
Should this be replacing the existing Sui withdraw and call example? https://github.com/zeta-chain/example-contracts/tree/main/examples/call/sui/sources |
|
Currently, we're encoding the payload for withdraw and call like so: Is this compatible to how it's done in this example? |
No compatibility will be broken because |
…add v2 gateway package ID to published-at field
| ) { | ||
| // check if the message is "revert" and revert with faked ENonceMismatch if so | ||
| if (data == b"revert") { | ||
| assert!(false, ENonceMismatch); |
There was a problem hiding this comment.
shouldnt nonce mismatch come from gateway and not related to example contract? maybe im missing some context
| let actual_sender = message_context_sender(message_context); | ||
| assert!(authenticated_sender == actual_sender, EUnauthorizedSender); | ||
|
|
||
| // check if the target package is my own package |
There was a problem hiding this comment.
is this checking if its coming from gateway? maybe some clarification on my own package would be great
The contents of this PR:
contractsfolder to contain bothgatewayandexamplepackages. Update the path in workflow accordingly.protocol-contracts-sui.Gatewayobject reference from example package'son_callmethod to fix deployment error.published-atfield to the gateway package Move.toml file.