dts: renesas: fix syntax error in multiple DTS/DTSI files #99423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Boards/SoCs
platform: Renesas R-Car
zephyrbot
requested review from
KhiemNguyenT,
duynguyenxa,
khoa-nguyen-18,
lorc,
soburi,
thaoluonguw,
thenguyenyf and
xakep-amatop
gurland
force-pushed
the
fix-renesas-ra6-ra8-dtsi-syntax
branch
from
996e85b to
b8dee83
Compare
Properties in bclk nodes were defined after the bclkout subnode, disk subnode was defined before properties in a few boards DTS files which violates the Devicetree Specification v0.4, section 6.3: "Nodes may contain property definitions and/or child node definitions. If both are present, properties shall come before child nodes." This caused the Device Tree Compiler error: "Properties must precede subnodes. Unable to parse input tree" This commit moves nested nodes after properties, fixing the syntax error and ensuring compliance with the Devicetree Specification. Signed-off-by: Stanislav Bobokalo <[email protected]>
gurland
force-pushed
the
fix-renesas-ra6-ra8-dtsi-syntax
branch
from
b8dee83 to
dfd51de
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties in
bclknodes were defined after the bclkout subnode,disksubnode was defined before properties in a few boards DTS files which violates the Devicetree Specification v0.4, section 6.3:"Nodes may contain property definitions and/or child node definitions. If both are present, properties shall come before child nodes."
This caused the Device Tree Compiler error: "Properties must precede subnodes. Unable to parse input tree"
This commit is simmilar to #97295 and moves nested nodes after properties, fixing those syntax errors and ensuring compliance with the Devicetree Specification.