Skip to content

fix: use strict equality checks for vote count and minId logic in Ran… #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeng407 merged 1 commit into from
Feb 5, 2026
Merged

fix: use strict equality checks for vote count and minId logic in Ran… #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions app/Services/Builders/RankReportHistoryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ protected function updateThousandVotesIncremental(array $cachedSummary)

$newCount = $newVotes->count();

if ($newCount == 0) {
if ($newCount === 0) {
return;
}

Expand Down Expand Up @@ -364,19 +364,12 @@ protected function updateThousandVotesIncremental(array $cachedSummary)
$winOutdated = $outdatedSlice->where('winner_id', $this->report->element_id)->count();
$loseOutdated = $outdatedSlice->where('loser_id', $this->report->element_id)->count();

// 新的 min_id 是被移除區段後的下一筆資料 ID
// 如果 outdatedVotes 數量足夠，last() 就是新的起點
if ($outdatedVotes->count() > $countToRemove) {
$newMinId = $outdatedVotes->last()->id;
} else {
// 防呆：如果資料庫剛好斷層，取最後一筆
$newMinId = $outdatedVotes->last()->id;
}
$newMinId = $outdatedVotes->last()->id;
}
}
// [情況 B] 總數還沒滿 1000，不需要移除舊資料
// 但如果是第一次建立 ($minId == 0)，需要設定 minId
elseif ($minId == 0 && $newCount > 0) {
elseif ($minId === 0 && $newCount > 0) {
// 因為 $newVotes 是 orderByDesc，所以最後一筆是 ID 最小的
$newMinId = $newVotes->last()->id;
}
Expand Down